src/language/goLanguageServer: fix parameter hint setting query

The language server middleware arranges to trigger the parameter hints
tooltip after completion items are accepted by checking users' settings.
But we should've referenced 'editor.parameterHints.enable'
'editor.parameterHints' workspace setting to check whether parameter
hint is enabled. This bug was introduced in cl/382234 during cleanup.
Unfortunately, it's not easy to write a useful test that could've
caught this type of bugs. Manually tested.

Fixes #3071

Change-Id: Ib2afbccb52dfcd17606148041794339fe4ba5355
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/546155
TryBot-Result: kokoro <[email protected]>
Reviewed-by: Suzy Mueller <[email protected]>
Commit-Queue: Hyang-Ah Hana Kim <[email protected]>

Author: hyangah

src/language/goLanguageServer.ts

@@ -650,13 +650,13 @@ export async function buildLanguageClient(
 							item.filterText = hardcodedFilterText;
 						}
 					}
-					const paramHintsEnabled = vscode.workspace.getConfiguration('editor.parameterHints', {
+					const paramHints = vscode.workspace.getConfiguration('editor.parameterHints', {
 						languageId: 'go',
 						uri: document.uri
 					});
 					// If the user has parameterHints (signature help) enabled,
 					// trigger it for function or method completion items.
-					if (paramHintsEnabled) {
+					if (paramHints.get<boolean>('enabled') === true) {
 						for (const item of items) {
 							if (item.kind === CompletionItemKind.Method || item.kind === CompletionItemKind.Function) {
 								item.command = {