Skip to content

Commit 6bafa62

Browse files
committed
extension/tools/release: use v0.43.0 and v0.44.0 in testing
The next change implements prerelease version package/publish steps. We use odd minor version number for prerelease, and while minor version number for stable release. Update the test dataset to use v0.43.0 and v0.44.0 instead of v0.0.0. So, in the next change, the diff presents the difference between prerelease vs stable release clearly. We keep release candidate version handling for now. So, we can still create a release candidate version before the stable release. After we are confident about the updated release process, we can think about skipping the release candidate creation step in favor of prerelease versions. For #1935 Change-Id: Ie88cd7932abb992fcb0b2a925b7c69de84d946ba Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/595380 Reviewed-by: Hongxiang Jiang <[email protected]> kokoro-CI: kokoro <[email protected]> Commit-Queue: Hyang-Ah Hana Kim <[email protected]>
1 parent e6d469b commit 6bafa62

11 files changed

+28
-16
lines changed

extension/tools/release/release_test.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,11 @@ func TestRelease(t *testing.T) {
3232
"publish -in=/tmp/artifacts",
3333
} {
3434
args := strings.Fields(fullCommand)
35-
for _, tagName := range []string{"v0.0.0", "v0.0.0-rc.1"} {
35+
// v0.43.0: prerelease
36+
// v0.44.0-rc.1: release candidate of stable release
37+
// v0.44.0: stable release
38+
// TODO(hyangah): skip rc in favor of prerelease versions.
39+
for _, tagName := range []string{"v0.43.0", "v0.44.0-rc.1", "v0.44.0"} {
3640
t.Run(args[0]+"-"+tagName, func(t *testing.T) {
3741
testRelease(t, moduleRoot, args[0], tagName, args[1:]...)
3842
})

extension/tools/release/testdata/package-v0.0.0-rc.1.golden

Lines changed: 0 additions & 3 deletions
This file was deleted.

extension/tools/release/testdata/package-v0.0.0.golden

Lines changed: 0 additions & 3 deletions
This file was deleted.
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
jq -r .version package.json
2+
cp ../README.md README.md
3+
npx vsce package -o /tmp/artifacts/go-0.43.0.vsix --baseContentUrl https://github.com/golang/vscode-go/raw/v0.43.0 --baseImagesUrl https://github.com/golang/vscode-go/raw/v0.43.0 --no-update-package-json --no-git-tag-version 0.43.0
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
jq -r .version package.json
2+
cp ../README.md README.md
3+
npx vsce package -o /tmp/artifacts/go-0.44.0-rc.1.vsix --baseContentUrl https://github.com/golang/vscode-go/raw/v0.44.0-rc.1 --baseImagesUrl https://github.com/golang/vscode-go/raw/v0.44.0-rc.1 --no-update-package-json --no-git-tag-version 0.44.0-rc.1
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
jq -r .version package.json
2+
cp ../README.md README.md
3+
npx vsce package -o /tmp/artifacts/go-0.44.0.vsix --baseContentUrl https://github.com/golang/vscode-go/raw/v0.44.0 --baseImagesUrl https://github.com/golang/vscode-go/raw/v0.44.0 --no-update-package-json --no-git-tag-version 0.44.0

extension/tools/release/testdata/publish-v0.0.0-rc.1.golden

Lines changed: 0 additions & 4 deletions
This file was deleted.

extension/tools/release/testdata/publish-v0.0.0.golden

Lines changed: 0 additions & 5 deletions
This file was deleted.
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
jq -r .version package.json
2+
stat /tmp/artifacts/go-0.43.0.vsix
3+
release create --generate-notes --target 4893cd984d190bdf2cd65e11c425b42819ae6f57 --title Release v0.43.0 --draft
4+
gh release create --generate-notes --target 4893cd984d190bdf2cd65e11c425b42819ae6f57 --title Release v0.43.0 --draft -R github.com/golang/vscode-go v0.43.0 /tmp/artifacts/go-0.43.0.vsix
5+
npx vsce publish -i /tmp/artifacts/go-0.43.0.vsix
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
jq -r .version package.json
2+
stat /tmp/artifacts/go-0.44.0-rc.1.vsix
3+
release create --generate-notes --target 4893cd984d190bdf2cd65e11c425b42819ae6f57 --title Release v0.44.0-rc.1 --draft
4+
gh release create --generate-notes --target 4893cd984d190bdf2cd65e11c425b42819ae6f57 --title Release v0.44.0-rc.1 --draft --prerelease -R github.com/golang/vscode-go v0.44.0-rc.1 /tmp/artifacts/go-0.44.0-rc.1.vsix
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
jq -r .version package.json
2+
stat /tmp/artifacts/go-0.44.0.vsix
3+
release create --generate-notes --target 4893cd984d190bdf2cd65e11c425b42819ae6f57 --title Release v0.44.0 --draft
4+
gh release create --generate-notes --target 4893cd984d190bdf2cd65e11c425b42819ae6f57 --title Release v0.44.0 --draft -R github.com/golang/vscode-go v0.44.0 /tmp/artifacts/go-0.44.0.vsix
5+
npx vsce publish -i /tmp/artifacts/go-0.44.0.vsix

0 commit comments

Comments
 (0)