fix: the randomness of the results of the analysis

Author: ldez

pkg/lint/linter/config.go

@@ -20,6 +20,9 @@ const (
 	PresetUnused      = "unused"      // Related to the detection of unused code.
 )
 
+// LastLinter nolintlint must be last because it looks at the results of all the previous linters for unused nolint directives.
+const LastLinter = "nolintlint"
+
 type Deprecation struct {
 	Since       string
 	Message     string

pkg/lint/lintersdb/enabled_set.go

@@ -111,6 +111,15 @@ func (es EnabledSet) GetOptimizedLinters() ([]*linter.Config, error) {
 	// Make order of execution of linters (go/analysis metalinter and unused) stable.
 	sort.Slice(resultLinters, func(i, j int) bool {
 		a, b := resultLinters[i], resultLinters[j]
+
+		if b.Name() == linter.LastLinter {
+			return true
+		}
+
+		if a.Name() == linter.LastLinter {
+			return false
+		}
+
 		if a.DoesChangeTypes != b.DoesChangeTypes {
 			return b.DoesChangeTypes // move type-changing linters to the end to optimize speed
 		}
@@ -149,8 +158,19 @@ func (es EnabledSet) combineGoAnalysisLinters(linters map[string]*linter.Config)
 
 	// Make order of execution of go/analysis analyzers stable.
 	sort.Slice(goanalysisLinters, func(i, j int) bool {
-		return strings.Compare(goanalysisLinters[i].Name(), goanalysisLinters[j].Name()) <= 0
+		a, b := goanalysisLinters[i], goanalysisLinters[j]
+
+		if b.Name() == linter.LastLinter {
+			return true
+		}
+
+		if a.Name() == linter.LastLinter {
+			return false
+		}
+
+		return strings.Compare(a.Name(), b.Name()) <= 0
 	})
+
 	ml := goanalysis.NewMetaLinter(goanalysisLinters)
 
 	var presets []string