support config and fix issues in self project

Author: golangcidev

.golangci.example.yml

@@ -0,0 +1,58 @@
+run:
+  args:
+    - ./...
+  verbose: true
+  concurrency: 4
+  deadline: 1m
+  issues-exit-code: 1
+  tests: true
+  build-tags:
+    - mytag
+
+output:
+  format: colored-line-number
+  print-issued-lines: true
+  print-linter-name: true
+  print-welcome: true
+
+linters-settings:
+  errcheck:
+    check-type-assertions: false
+    check-blank: false
+  govet:
+    check-shadowing: true
+  golint:
+    min-confidence: 0.8
+  gofmt:
+    simplify: true
+  gocyclo:
+    min-complexity: 10
+  maligned:
+    suggest-new: true
+  dupl:
+    threshold: 50
+  goconst:
+    min-len: 3
+    min-occurrences: 3
+
+linters:
+  enable:
+    - megacheck
+    - vet
+  enable-all: true
+  disable:
+    maligned
+  disable-all: false
+  presets:
+    - bugs
+    - unused
+
+issues:
+  exclude:
+    - abcdef
+  exclude-use-default: true
+  max-per-linter: 0
+  max-same: 0
+  new: false
+  new-from-rev: ""
+  new-from-patch: ""

.golangci.yml

@@ -0,0 +1,31 @@
+run:
+  verbose: true
+  deadline: 30s
+  tests: true
+
+linters-settings:
+  errcheck:
+    check-type-assertions: true
+    check-blank: true
+  govet:
+    check-shadowing: true
+  golint:
+    min-confidence: 0
+  gocyclo:
+    min-complexity: 10
+  maligned:
+    suggest-new: true
+  dupl:
+    threshold: 100
+  goconst:
+    min-len: 2
+    min-occurrences: 2
+
+linters:
+  enable-all: true
+  disable:
+    - maligned
+
+issues:
+  exclude:
+    - should have a package comment

Gopkg.lock

@@ -69,3 +69,7 @@
 [prune]
   go-tests = true
   unused-packages = true
+
+[[constraint]]
+  name = "github.com/spf13/viper"
+  version = "1.0.2"

Gopkg.toml

@@ -1,2 +1,3 @@
 test:
+	golangci-lint run
 	go test -v -race ./...

Makefile

@@ -15,7 +15,7 @@ type Executor struct {
 
 func NewExecutor() *Executor {
 	e := &Executor{
-		cfg: config.NewDefault(),
+		cfg: &config.Config{},
 	}
 
 	e.initRoot()

internal/commands/executor.go

@@ -16,17 +16,19 @@ func (e *Executor) initRoot() {
 		Short: "golangci-lint is a smart linters runner.",
 		Long:  `Smart, fast linters runner. Run it in cloud for every GitHub pull request on https://golangci.com`,
 		Run: func(cmd *cobra.Command, args []string) {
-			_ = cmd.Help()
+			if err := cmd.Help(); err != nil {
+				log.Fatal(err)
+			}
 		},
 		PersistentPreRun: func(cmd *cobra.Command, args []string) {
-			runtime.GOMAXPROCS(e.cfg.Common.Concurrency)
+			runtime.GOMAXPROCS(e.cfg.Run.Concurrency)
 
-			if e.cfg.Common.IsVerbose {
+			if e.cfg.Run.IsVerbose {
 				logrus.SetLevel(logrus.InfoLevel)
 			}
 
-			if e.cfg.Common.CPUProfilePath != "" {
-				f, err := os.Create(e.cfg.Common.CPUProfilePath)
+			if e.cfg.Run.CPUProfilePath != "" {
+				f, err := os.Create(e.cfg.Run.CPUProfilePath)
 				if err != nil {
 					log.Fatal(err)
 				}
@@ -36,14 +38,15 @@ func (e *Executor) initRoot() {
 			}
 		},
 		PersistentPostRun: func(cmd *cobra.Command, args []string) {
-			if e.cfg.Common.CPUProfilePath != "" {
+			if e.cfg.Run.CPUProfilePath != "" {
 				pprof.StopCPUProfile()
 			}
 			os.Exit(e.exitCode)
 		},
 	}
-	rootCmd.PersistentFlags().BoolVarP(&e.cfg.Common.IsVerbose, "verbose", "v", false, "verbose output")
-	rootCmd.PersistentFlags().StringVar(&e.cfg.Common.CPUProfilePath, "cpu-profile-path", "", "Path to CPU profile output file")
-	rootCmd.PersistentFlags().IntVarP(&e.cfg.Common.Concurrency, "concurrency", "j", runtime.NumCPU(), "Concurrency")
+	rootCmd.PersistentFlags().BoolVarP(&e.cfg.Run.IsVerbose, "verbose", "v", false, "verbose output")
+	rootCmd.PersistentFlags().StringVar(&e.cfg.Run.CPUProfilePath, "cpu-profile-path", "", "Path to CPU profile output file")
+	rootCmd.PersistentFlags().IntVarP(&e.cfg.Run.Concurrency, "concurrency", "j", runtime.NumCPU(), "Concurrency")
+
 	e.rootCmd = rootCmd
 }