Skip to content

govet printf in go 1.22.5 with golangci-lint v1.57.2 #4936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
6 of 7 tasks
hjkatz opened this issue Aug 21, 2024 · 7 comments
Closed
6 of 7 tasks

govet printf in go 1.22.5 with golangci-lint v1.57.2 #4936

hjkatz opened this issue Aug 21, 2024 · 7 comments
Labels
feedback required Requires additional feedback

Comments

@hjkatz
Copy link

hjkatz commented Aug 21, 2024 •
edited by ldez
Loading

Welcome

  • Yes, I'm using a binary release within 2 latest releases. Only such installations are supported.
  • Yes, I've searched similar issues on GitHub and didn't find any.
  • Yes, I've read the typecheck section of the FAQ.
  • Yes, I've tried with the standalone linter if available (e.g., gocritic, go vet, etc.).
  • I agree to follow this project's Code of Conduct

Description of the problem

See: golang/go#60529 (comment)

Basically I'm seeing the new govet printf checks in older versions of golangci-lint and on go 1.22.5.

I've tried some combinations of go versions and golangci-lint versions, but no luck because I run into this bug with any golangci-lint v1.60+ -> #4933

Here's the command I use to install golangci-lint:

$ go install -v -buildvcs=true -trimpath github.com/golangci/golangci-lint/cmd/golangci-lint

Here's the go.mod

$ go mod graph | grep golangci-lint
go.ngrok.com github.com/golangci/[email protected]
github.com/golangci/[email protected] 4d63.com/[email protected]
github.com/golangci/[email protected] 4d63.com/[email protected]
github.com/golangci/[email protected] github.com/4meepo/[email protected]
github.com/golangci/[email protected] github.com/Abirdcfly/[email protected]
github.com/golangci/[email protected] github.com/Antonboom/[email protected]
github.com/golangci/[email protected] github.com/Antonboom/[email protected]
github.com/golangci/[email protected] github.com/Antonboom/[email protected]
github.com/golangci/[email protected] github.com/BurntSushi/[email protected]
github.com/golangci/[email protected] github.com/Djarvur/[email protected]
github.com/golangci/[email protected] github.com/GaijinEntertainment/go-exhaustruct/[email protected]
github.com/golangci/[email protected] github.com/OpenPeeDeeP/depguard/[email protected]
github.com/golangci/[email protected] github.com/alecthomas/[email protected]
github.com/golangci/[email protected] github.com/alexkohler/nakedret/[email protected]
github.com/golangci/[email protected] github.com/alexkohler/[email protected]
github.com/golangci/[email protected] github.com/alingse/[email protected]
github.com/golangci/[email protected] github.com/ashanbrown/[email protected]
github.com/golangci/[email protected] github.com/ashanbrown/[email protected]
github.com/golangci/[email protected] github.com/bkielbasa/[email protected]
github.com/golangci/[email protected] github.com/blizzy78/[email protected]
github.com/golangci/[email protected] github.com/bombsimon/wsl/[email protected]
github.com/golangci/[email protected] github.com/breml/[email protected]
github.com/golangci/[email protected] github.com/breml/[email protected]
github.com/golangci/[email protected] github.com/butuzov/[email protected]
github.com/golangci/[email protected] github.com/butuzov/[email protected]
github.com/golangci/[email protected] github.com/catenacyber/[email protected]
github.com/golangci/[email protected] github.com/charithe/[email protected]
github.com/golangci/[email protected] github.com/ckaznocha/[email protected]
github.com/golangci/[email protected] github.com/curioswitch/[email protected]
github.com/golangci/[email protected] github.com/daixiang0/[email protected]
github.com/golangci/[email protected] github.com/denis-tingaikin/[email protected]
github.com/golangci/[email protected] github.com/fatih/[email protected]
github.com/golangci/[email protected] github.com/firefart/[email protected]
github.com/golangci/[email protected] github.com/fzipp/[email protected]
github.com/golangci/[email protected] github.com/ghostiam/[email protected]
github.com/golangci/[email protected] github.com/go-critic/[email protected]
github.com/golangci/[email protected] github.com/go-viper/mapstructure/[email protected]
github.com/golangci/[email protected] github.com/go-xmlfmt/[email protected]
github.com/golangci/[email protected] github.com/gofrs/[email protected]
github.com/golangci/[email protected] github.com/golangci/[email protected]
github.com/golangci/[email protected] github.com/golangci/[email protected]
github.com/golangci/[email protected] github.com/golangci/[email protected]
github.com/golangci/[email protected] github.com/golangci/[email protected]
github.com/golangci/[email protected] github.com/golangci/[email protected]
github.com/golangci/[email protected] github.com/golangci/[email protected]
github.com/golangci/[email protected] github.com/gordonklaus/[email protected]
github.com/golangci/[email protected] github.com/gostaticanalysis/[email protected]
github.com/golangci/[email protected] github.com/gostaticanalysis/[email protected]
github.com/golangci/[email protected] github.com/hashicorp/[email protected]
github.com/golangci/[email protected] github.com/hexops/[email protected]
github.com/golangci/[email protected] github.com/jgautheron/[email protected]
github.com/golangci/[email protected] github.com/jingyugao/[email protected]
github.com/golangci/[email protected] github.com/jirfag/[email protected]
github.com/golangci/[email protected] github.com/jjti/[email protected]
github.com/golangci/[email protected] github.com/julz/[email protected]
github.com/golangci/[email protected] github.com/karamaru-alpha/[email protected]
github.com/golangci/[email protected] github.com/kisielk/[email protected]
github.com/golangci/[email protected] github.com/kkHAIKE/[email protected]
github.com/golangci/[email protected] github.com/kulti/[email protected]
github.com/golangci/[email protected] github.com/kunwardeep/[email protected]
github.com/golangci/[email protected] github.com/kyoh86/[email protected]
github.com/golangci/[email protected] github.com/ldez/[email protected]
github.com/golangci/[email protected] github.com/ldez/[email protected]
github.com/golangci/[email protected] github.com/leonklingele/[email protected]
github.com/golangci/[email protected] github.com/lufeee/[email protected]
github.com/golangci/[email protected] github.com/macabu/[email protected]
github.com/golangci/[email protected] github.com/maratori/[email protected]
github.com/golangci/[email protected] github.com/maratori/[email protected]
github.com/golangci/[email protected] github.com/matoous/[email protected]
github.com/golangci/[email protected] github.com/mattn/[email protected]
github.com/golangci/[email protected] github.com/mgechev/[email protected]
github.com/golangci/[email protected] github.com/mitchellh/[email protected]
github.com/golangci/[email protected] github.com/mitchellh/[email protected]
github.com/golangci/[email protected] github.com/moricho/[email protected]
github.com/golangci/[email protected] github.com/nakabonne/[email protected]
github.com/golangci/[email protected] github.com/nishanths/[email protected]
github.com/golangci/[email protected] github.com/nishanths/[email protected]
github.com/golangci/[email protected] github.com/nunnatsa/[email protected]
github.com/golangci/[email protected] github.com/pelletier/go-toml/[email protected]
github.com/golangci/[email protected] github.com/polyfloyd/[email protected]
github.com/golangci/[email protected] github.com/quasilyte/go-ruleguard/[email protected]
github.com/golangci/[email protected] github.com/ryancurrah/[email protected]
github.com/golangci/[email protected] github.com/ryanrolds/[email protected]
github.com/golangci/[email protected] github.com/sanposhiho/wastedassign/[email protected]
github.com/golangci/[email protected] github.com/santhosh-tekuri/jsonschema/[email protected]
github.com/golangci/[email protected] github.com/sashamelentyev/[email protected]
github.com/golangci/[email protected] github.com/sashamelentyev/[email protected]
github.com/golangci/[email protected] github.com/securego/gosec/[email protected]
github.com/golangci/[email protected] github.com/shazow/[email protected]
github.com/golangci/[email protected] github.com/shirou/gopsutil/[email protected]
github.com/golangci/[email protected] github.com/sirupsen/[email protected]
github.com/golangci/[email protected] github.com/sivchari/[email protected]
github.com/golangci/[email protected] github.com/sivchari/[email protected]
github.com/golangci/[email protected] github.com/sonatard/[email protected]
github.com/golangci/[email protected] github.com/sourcegraph/[email protected]
github.com/golangci/[email protected] github.com/spf13/[email protected]
github.com/golangci/[email protected] github.com/spf13/[email protected]
github.com/golangci/[email protected] github.com/spf13/[email protected]
github.com/golangci/[email protected] github.com/ssgreg/nlreturn/[email protected]
github.com/golangci/[email protected] github.com/stbenjam/[email protected]
github.com/golangci/[email protected] github.com/stretchr/[email protected]
github.com/golangci/[email protected] github.com/tdakkota/[email protected]
github.com/golangci/[email protected] github.com/tetafro/[email protected]
github.com/golangci/[email protected] github.com/timakin/[email protected]
github.com/golangci/[email protected] github.com/timonwong/[email protected]
github.com/golangci/[email protected] github.com/tomarrell/wrapcheck/[email protected]
github.com/golangci/[email protected] github.com/tommy-muehle/go-mnd/[email protected]
github.com/golangci/[email protected] github.com/ultraware/[email protected]
github.com/golangci/[email protected] github.com/ultraware/[email protected]
github.com/golangci/[email protected] github.com/uudashr/[email protected]
github.com/golangci/[email protected] github.com/valyala/[email protected]
github.com/golangci/[email protected] github.com/xen0n/[email protected]
github.com/golangci/[email protected] github.com/yagipy/[email protected]
github.com/golangci/[email protected] github.com/yeya24/[email protected]
github.com/golangci/[email protected] github.com/ykadowak/[email protected]
github.com/golangci/[email protected] gitlab.com/bosi/[email protected]
github.com/golangci/[email protected] go-simpler.org/[email protected]
github.com/golangci/[email protected] go-simpler.org/[email protected]
github.com/golangci/[email protected] go.uber.org/[email protected]
github.com/golangci/[email protected] golang.org/x/[email protected]
github.com/golangci/[email protected] golang.org/x/[email protected]
github.com/golangci/[email protected] gopkg.in/[email protected]
github.com/golangci/[email protected] honnef.co/go/[email protected]
github.com/golangci/[email protected] mvdan.cc/[email protected]
github.com/golangci/[email protected] mvdan.cc/[email protected]
github.com/golangci/[email protected] github.com/Masterminds/[email protected]
github.com/golangci/[email protected] github.com/beorn7/[email protected]
github.com/golangci/[email protected] github.com/ccojocar/[email protected]
github.com/golangci/[email protected] github.com/cespare/xxhash/[email protected]
github.com/golangci/[email protected] github.com/chavacava/[email protected]
github.com/golangci/[email protected] github.com/davecgh/[email protected]
github.com/golangci/[email protected] github.com/ettle/[email protected]
github.com/golangci/[email protected] github.com/fatih/[email protected]
github.com/golangci/[email protected] github.com/fsnotify/[email protected]
github.com/golangci/[email protected] github.com/go-ole/[email protected]
github.com/golangci/[email protected] github.com/go-toolsmith/[email protected]
github.com/golangci/[email protected] github.com/go-toolsmith/[email protected]
github.com/golangci/[email protected] github.com/go-toolsmith/[email protected]
github.com/golangci/[email protected] github.com/go-toolsmith/[email protected]
github.com/golangci/[email protected] github.com/go-toolsmith/[email protected]
github.com/golangci/[email protected] github.com/go-toolsmith/[email protected]
github.com/golangci/[email protected] github.com/go-toolsmith/[email protected]
github.com/golangci/[email protected] github.com/gobwas/[email protected]
github.com/golangci/[email protected] github.com/golang/[email protected]
github.com/golangci/[email protected] github.com/google/[email protected]
github.com/golangci/[email protected] github.com/gostaticanalysis/[email protected]
github.com/golangci/[email protected] github.com/gostaticanalysis/[email protected]
github.com/golangci/[email protected] github.com/hashicorp/[email protected]
github.com/golangci/[email protected] github.com/inconshreveable/[email protected]
github.com/golangci/[email protected] github.com/lufia/[email protected]
github.com/golangci/[email protected] github.com/magiconair/[email protected]
github.com/golangci/[email protected] github.com/mattn/[email protected]
github.com/golangci/[email protected] github.com/mattn/[email protected]
github.com/golangci/[email protected] github.com/matttproud/[email protected]
github.com/golangci/[email protected] github.com/mitchellh/[email protected]
github.com/golangci/[email protected] github.com/olekukonko/[email protected]
github.com/golangci/[email protected] github.com/pelletier/[email protected]
github.com/golangci/[email protected] github.com/pmezard/[email protected]
github.com/golangci/[email protected] github.com/power-devops/[email protected]
github.com/golangci/[email protected] github.com/prometheus/[email protected]
github.com/golangci/[email protected] github.com/prometheus/[email protected]
github.com/golangci/[email protected] github.com/prometheus/[email protected]
github.com/golangci/[email protected] github.com/prometheus/[email protected]
github.com/golangci/[email protected] github.com/quasilyte/[email protected]
github.com/golangci/[email protected] github.com/quasilyte/[email protected]
github.com/golangci/[email protected] github.com/quasilyte/regex/[email protected]
github.com/golangci/[email protected] github.com/quasilyte/[email protected]
github.com/golangci/[email protected] github.com/shoenig/[email protected]
github.com/golangci/[email protected] github.com/spf13/[email protected]
github.com/golangci/[email protected] github.com/spf13/[email protected]
github.com/golangci/[email protected] github.com/spf13/[email protected]
github.com/golangci/[email protected] github.com/stretchr/[email protected]
github.com/golangci/[email protected] github.com/subosito/[email protected]
github.com/golangci/[email protected] github.com/t-yuki/[email protected]
github.com/golangci/[email protected] github.com/tklauser/[email protected]
github.com/golangci/[email protected] github.com/tklauser/[email protected]
github.com/golangci/[email protected] github.com/valyala/[email protected]
github.com/golangci/[email protected] github.com/yusufpapurcu/[email protected]
github.com/golangci/[email protected] go.uber.org/[email protected]
github.com/golangci/[email protected] go.uber.org/[email protected]
github.com/golangci/[email protected] go.uber.org/[email protected]
github.com/golangci/[email protected] golang.org/x/exp/[email protected]
github.com/golangci/[email protected] golang.org/x/[email protected]
github.com/golangci/[email protected] golang.org/x/[email protected]
github.com/golangci/[email protected] golang.org/x/[email protected]
github.com/golangci/[email protected] golang.org/x/[email protected]
github.com/golangci/[email protected] google.golang.org/[email protected]
github.com/golangci/[email protected] gopkg.in/[email protected]
github.com/golangci/[email protected] gopkg.in/[email protected]
github.com/golangci/[email protected] [email protected]
github.com/sters/[email protected] github.com/golangci/[email protected]

Version of golangci-lint

$ golangci-lint --version
# Paste output here

Configuration

# paste configuration file or CLI flags here

Go environment

$ go version && go env
# paste output here

Verbose output of running

$ golangci-lint cache clean
$ golangci-lint run -v
# paste output here

A minimal reproducible example or link to a public repository

// add your code here

Validation

  • Yes, I've included all information above (version, config, etc.).

Supporter
@hjkatz hjkatz added the bug Something isn't working label Aug 21, 2024
@boring-cyborg boring-cyborg
Copy link

boring-cyborg bot commented Aug 21, 2024

Hey, thank you for opening your first Issue ! 🙂 If you would like to contribute we have a guide for contributors.

@ldez
Copy link
Member

ldez commented Aug 21, 2024 •
edited
Loading

Hello,

You have checked:

[x] Yes, I'm using a binary release within 2 latest releases. Only such installations are supported.

But you are using v1.57.2 (2024-03-28)

I've tried some combinations of go versions and golangci-lint versions, but no luck because I run into this bug with any golangci-lint v1.60+

You should use golangci-lint v1.60.2 built with go1.23.

We only supported the latest version of golangci-lint as explained in the issue template.

Basically I'm seeing the new govet printf checks in older versions of golangci-lint and on go 1.22.5.

The govet rules are not dependent on the Go version but on golang.org/x/tools version used to compile.

Also, the updated printf rule is a best practice and can be applied to any Go code base.

Also, we discourage the usage of go install: https://golangci-lint.run/welcome/install/#install-from-source

To be able to process your issue as quickly as possible,
can you edit your issue to add missing elements, fix the invalid elements, and complete the sections?

Section Status
Welcome 🟠
Description of the problem 🟠
Version of golangci-lint 🔴
Configuration 🔴
Go environment 🔴
Verbose output of running 🔴
A minimal reproducible example or link to a public repository 🔴
Validation 🔴
Supporter 🟢

Legend:

  • 🟢: The section is complete and valid.
  • 🟠: The section is incomplete.
  • 🔴: The section is missing or invalid.

@ldez ldez added feedback required Requires additional feedback and removed bug Something isn't working labels Aug 21, 2024
@hjkatz
Copy link
Author

hjkatz commented Aug 22, 2024

@ldez I didn't realize that go 1.23 was released (I was at the beach 🙈). I'll try upgrading and report back, thanks!

@hjkatz
Copy link
Author

hjkatz commented Aug 22, 2024 

$ golangci-lint --version
golangci-lint has version v1.60.2 built with go1.23.0 from (unknown, modified: ?, mod sum: "h1:Y8aWnZCMOLY5T7Ga5hcoemyKsZZJCUmIIK3xTD3jIhc=") on (unknown

Ok on this version (with golang.org/x/tools v0.24.0 (latest) I see the hanging and memory usage issue as reported here: #4933

@hjkatz
Copy link
Author

hjkatz commented Aug 22, 2024

I let it run for a while and eventually received a panic:

golangci-lint run ./...
ERRO [runner] Panic: errcheck: package "tcp" (isInitialPkg: true, needAnalyzeSource: true): cannot get Field of a type that is not a struct, got a *types.Alias: goroutine 162981 [running]:
runtime/debug.Stack()
	runtime/debug/stack.go:26 +0x5e
github.com/golangci/golangci-lint/pkg/goanalysis.(*action).analyzeSafe.func1()
	github.com/golangci/[email protected]/pkg/goanalysis/runner_action.go:109 +0x277
panic({0x18d9a60?, 0xc163ffab40?})
	runtime/panic.go:785 +0x132
github.com/kisielk/errcheck/errcheck.getTypeAtFieldIndex({0x1e06290?, 0xc09f2110d0?}, 0x32?)
	github.com/kisielk/[email protected]/errcheck/embedded_walker.go:90 +0xdd
github.com/kisielk/errcheck/errcheck.walkThroughEmbeddedInterfaces(0x196b0c0?)
	github.com/kisielk/[email protected]/errcheck/embedded_walker.go:49 +0x8e
github.com/kisielk/errcheck/errcheck.(*visitor).namesForExcludeCheck(0xc088c00000, 0xc15fbf1f00?)
	github.com/kisielk/[email protected]/errcheck/errcheck.go:362 +0x165
github.com/kisielk/errcheck/errcheck.(*visitor).excludeCall(0xc088c00000, 0xc15fbf1f00?)
	github.com/kisielk/[email protected]/errcheck/errcheck.go:401 +0x72
github.com/kisielk/errcheck/errcheck.(*visitor).ignoreCall(0xc088c00000, 0xc15fbf1f00)
	github.com/kisielk/[email protected]/errcheck/errcheck.go:413 +0x2c
github.com/kisielk/errcheck/errcheck.(*visitor).Visit(0xc088c00000, {0x1e05888?, 0xc043a94f30})
	github.com/kisielk/[email protected]/errcheck/errcheck.go:560 +0x137
go/ast.Walk({0x1dff2e0?, 0xc088c00000?}, {0x1e05888, 0xc043a94f30})
	go/ast/walk.go:34 +0x4c
go/ast.walkList[...](...)
	go/ast/walk.go:21
go/ast.Walk({0x1dff2e0?, 0xc088c00000?}, {0x1e05338, 0xc15a5ff1d0})
	go/ast/walk.go:211 +0x30ad
go/ast.Walk({0x1dff2e0?, 0xc088c00000?}, {0x1e05360, 0xc1609040c0})
	go/ast/walk.go:220 +0x2abe
go/ast.walkList[...](...)
	go/ast/walk.go:21
go/ast.Walk({0x1dff2e0?, 0xc088c00000?}, {0x1e05338, 0xc15a5ff200})
	go/ast/walk.go:211 +0x30ad
go/ast.Walk({0x1dff2e0?, 0xc088c00000?}, {0x1e051d0, 0xc043a94fd0})
	go/ast/walk.go:78 +0x8e8
go/ast.walkList[...](...)
	go/ast/walk.go:21
go/ast.Walk({0x1dff2e0?, 0xc088c00000?}, {0x1e056d0, 0xc160904140})
	go/ast/walk.go:121 +0x2776
go/ast.walkList[...](...)
	go/ast/walk.go:21
go/ast.Walk({0x1dff2e0?, 0xc088c00000?}, {0x1e05950, 0xc1609028e0})
	go/ast/walk.go:203 +0x179e
go/ast.walkList[...](...)
	go/ast/walk.go:21
go/ast.Walk({0x1dff2e0?, 0xc088c00000?}, {0x1e05338, 0xc15a5ff260})
	go/ast/walk.go:211 +0x30ad
go/ast.Walk({0x1dff2e0?, 0xc088c00000?}, {0x1e04420, 0xc15a5ff290})
	go/ast/walk.go:332 +0xf7c
go/ast.walkList[...](...)
	go/ast/walk.go:21
go/ast.Walk({0x1dff2e0?, 0xc088c00000?}, {0x1e03a20, 0xc15a5b0d20})
	go/ast/walk.go:341 +0x3585
github.com/kisielk/errcheck/errcheck.(*Checker).CheckPackage(0xc0004b7dc0, 0xc00c8caad8)
	github.com/kisielk/[email protected]/errcheck/errcheck.go:235 +0x425
github.com/golangci/golangci-lint/pkg/golinters/errcheck.runErrCheck(0xc003747e60, 0xc079275960, 0xc0004b7dc0?)
	github.com/golangci/[email protected]/pkg/golinters/errcheck/errcheck.go:82 +0xab
github.com/golangci/golangci-lint/pkg/golinters/errcheck.New.func1.1(0x196adc0?)
	github.com/golangci/[email protected]/pkg/golinters/errcheck/errcheck.go:54 +0x49
github.com/golangci/golangci-lint/pkg/goanalysis.(*action).analyze(0xc008b59d20)
	github.com/golangci/[email protected]/pkg/goanalysis/runner_action.go:191 +0x9cd
github.com/golangci/golangci-lint/pkg/goanalysis.(*action).analyzeSafe.func2()
	github.com/golangci/[email protected]/pkg/goanalysis/runner_action.go:113 +0x17
github.com/golangci/golangci-lint/pkg/timeutils.(*Stopwatch).TrackStage(0xc0024c37c0, {0x1b1ce94, 0x8}, 0xc00c04ff48)
	github.com/golangci/[email protected]/pkg/timeutils/stopwatch.go:111 +0x44
github.com/golangci/golangci-lint/pkg/goanalysis.(*action).analyzeSafe(0xc002f8d0b0?)
	github.com/golangci/[email protected]/pkg/goanalysis/runner_action.go:112 +0x6e
github.com/golangci/golangci-lint/pkg/goanalysis.(*loadingPackage).analyze.func2(0xc008b59d20)
	github.com/golangci/[email protected]/pkg/goanalysis/runner_loadingpackage.go:82 +0xa5
created by github.com/golangci/golangci-lint/pkg/goanalysis.(*loadingPackage).analyze in goroutine 9822
	github.com/golangci/[email protected]/pkg/goanalysis/runner_loadingpackage.go:77 +0x1e9
WARN [runner] Can't run linter goanalysis_metalinter: goanalysis_metalinter: errcheck: package "tcp" (isInitialPkg: true, needAnalyzeSource: true): cannot get Field of a type that is not a struct, got a *types.Alias
ERRO Running error: can't run linter goanalysis_metalinter
goanalysis_metalinter: errcheck: package "tcp" (isInitialPkg: true, needAnalyzeSource: true): cannot get Field of a type that is not a struct, got a *types.Alias
golangci-lint run ./...  724.52s user 26.84s system 603% cpu 2:04.46 total

@hjkatz
Copy link
Author

hjkatz commented Aug 22, 2024

Ok, I got the following combination to work:

I'll stick with this for now.

I'm happy to open a separate issue for the panic above^ lmk what you would prefer.

@ldez
Copy link
Member

ldez commented Aug 22, 2024

If you have a reproducible example of the panic, you can open a new issue.

For the rest, I don't have enough information and it is unexpectecd that golangci-lint v1.60.2 built go1.23 has this behavior.
So I will close this issue until we have more information to reproduce the problem.

@ldez ldez closed this as completed Aug 22, 2024
@ldez ldez mentioned this issue Sep 12, 2024
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feedback required Requires additional feedback
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hjkatz @ldez