Skip to content

gocritic: importShadow rule doesn't appear to work #5672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
7 tasks done
thrasher- opened this issue Apr 1, 2025 · 6 comments · Fixed by #5673
Closed
7 tasks done

gocritic: importShadow rule doesn't appear to work #5672

thrasher- opened this issue Apr 1, 2025 · 6 comments · Fixed by #5673
Assignees
@ldez
Labels
bug Something isn't working

Comments

@thrasher-
Copy link

thrasher- commented Apr 1, 2025 •
edited
Loading

Welcome

  • Yes, I'm using a binary release within 2 latest releases. Only such installations are supported.
  • Yes, I've searched similar issues on GitHub and didn't find any.
  • Yes, I've read the typecheck section of the FAQ.
  • Yes, I've tried with the standalone linter if available (e.g., gocritic, go vet, etc.).
  • I agree to follow this project's Code of Conduct

How did you install golangci-lint?

Official binary

Description of the problem

When running golangci-lint with gocritic with enable-all enabled and a test function shadowing fmt, I'm getting no output to do with the issue. I then tried the gocritic tool manually gocritic check -enable importShadow ./... and it picked up those issues without any problems.

Version of golangci-lint

$ golangci-lint --version
# golangci-lint has version 2.0.2 built with go1.24.1 from 2b224c2c on 2025-03-25T21:36:18Z

Configuration

version: "2"
run:
  issues-exit-code: 1
  tests: true

linters:
  default: none
  enable:
# defaults
    - errcheck
    - govet
    - ineffassign
    - staticcheck
#   - unused

# disabled by default linters
#   - asasalint
    - asciicheck
    - bidichk
    - bodyclose
#   - canonicalheader
    - containedctx
#   - contextcheck
    - copyloopvar
#   - cyclop
    - decorder
    - depguard
    - dogsled
#   - dupl
    - dupword
    - durationcheck
#   - err113
    - errchkjson
    - errname
#   - errorlint
#   - exhaustive
#   - exhaustruct
#   - exptostd
    - fatcontext
#   - forbidigo
    - forcetypeassert
#   - funlen
#   - ginkgolinter
    - gocheckcompilerdirectives
#   - gochecknoglobals
#   - gochecknoinits
    - gochecksumtype
#   - gocognit
    - goconst
    - gocritic
#   - gocyclo
#   - godot
#   - godox
#   - goheader
    - gomoddirectives
    - gomodguard
    - goprintffuncname
    - gosec
#   - gosmopolitan
    - grouper
    - iface
#   - importas
#   - inamedparam
#   - interfacebloat
    - intrange
#   - ireturn
#   - lll
#   - loggercheck
#   - maintidx
    - makezero
    - mirror
    - misspell
#   - mnd
#   - musttag
#   - nakedret
#   - nestif
    - nilerr
    - nilnesserr
#   - nilnil
#   - nlreturn
    - noctx
    - nolintlint
#   - nonamedreturns
    - nosprintfhostport
#   - paralleltest
    - perfsprint
    - prealloc
    - predeclared
#   - promlinter
#   - protogetter
    - reassign
#   - recvcheck
    - revive
    - rowserrcheck
#   - sloglint
#   - spancheck
    - sqlclosecheck
    - tagalign
#   - tagliatelle
    - testableexamples
    - testifylint
#   - testpackage
    - thelper
    - tparallel
    - unconvert
    - unparam
    - usestdlibvars
    - usetesting
#   - varnamelen
    - wastedassign
    - whitespace
#   - wrapcheck
#   - wsl
#   - zerologlint

  settings:
    depguard:
      rules:
        prevent_json_package_use:
          list-mode: lax
          files:
            - $all
          allow:
            - github.com/thrasher-corp/gocryptotrader/encoding/json
          deny:
            - pkg: encoding/json
              desc: Please use the custom JSON package github.com/thrasher-corp/gocryptotrader/encoding/json instead of encoding/json to allow sonic/json switching.
    goconst:
      min-occurrences: 6
    gocritic:
      enable-all: true
      disabled-checks:
        - evalOrder
    govet:
      enable:
        - shadow
        - nilness
        - unusedwrite
    staticcheck:
      checks:
        - all
        - '-ST1000' # Disable at least one file in a package should have a package comment check
        - '-QF1005' # Disable expand call to math.Pow check
        - '-QF1008' # Disable embedded field from selector check
    testifylint:
      enable-all: true
      disable:
        - require-error
        - float-compare
         # We deliberately use Equal over Len to avoid spamming the contents of large Slices
        - len
  exclusions:
    generated: lax
    presets:
      - common-false-positives
      - legacy
      - std-error-handling
    rules:
      - linters:
          - gosec
        text: Expect WriteFile permissions to be 0600 or less
      - linters:
          - govet
        text: 'shadow: declaration of "err" shadows declaration at'
      - linters:
          - revive
        text: 'should have a package comment'
    paths:
      - vendor
      - web/
      - testdata
      - database/models/
      - third_party$
      - builtin$
      - examples$
issues:
  max-issues-per-linter: 0
  max-same-issues: 0
formatters:
  enable:
    - gci
    - gofmt
    - gofumpt
    - goimports
  settings:
    gofumpt:
      extra-rules: true
  exclusions:
    generated: lax
    paths:
      - vendor
      - web/
      - testdata
      - database/models/
      - third_party$
      - builtin$
      - examples$

Go environment

$ go version && go env
go version go1.24.1 windows/amd64
set AR=ar
set CC=gcc
set CGO_CFLAGS=-O2 -g
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-O2 -g
set CGO_ENABLED=1
set CGO_FFLAGS=-O2 -g
set CGO_LDFLAGS=-O2 -g
set CXX=g++
set GCCGO=gccgo
set GO111MODULE=
set GOAMD64=v1
set GOARCH=amd64
set GOAUTH=netrc
set GOBIN=
set GOCACHE=C:\Users\AdrianGallagher\AppData\Local\go-build
set GOCACHEPROG=
set GODEBUG=
set GOENV=C:\Users\AdrianGallagher\AppData\Roaming\go\env
set GOEXE=.exe
set GOEXPERIMENT=
set GOFIPS140=off
set GOFLAGS=
set GOGCCFLAGS=-m64 -mthreads -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=C:\Users\ADRIAN~1\AppData\Local\Temp\go-build2838124255=/tmp/go-build -gno-record-gcc-switches
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOINSECURE=
set GOMOD=C:\Users\AdrianGallagher\go\src\github.com\thrasher-corp\gocryptotrader\go.mod
set GOMODCACHE=C:\Users\AdrianGallagher\go\pkg\mod
set GONOPROXY=
set GONOSUMDB=
set GOOS=windows
set GOPATH=C:\Users\AdrianGallagher\go
set GOPRIVATE=
set GOPROXY=https://proxy.golang.org,direct
set GOROOT=C:\Program Files\Go
set GOSUMDB=sum.golang.org
set GOTELEMETRY=local
set GOTELEMETRYDIR=C:\Users\AdrianGallagher\AppData\Roaming\go\telemetry
set GOTMPDIR=
set GOTOOLCHAIN=auto
set GOTOOLDIR=C:\Program Files\Go\pkg\tool\windows_amd64
set GOVCS=
set GOVERSION=go1.24.1
set GOWORK=
set PKG_CONFIG=pkg-config

Verbose output of running

$ golangci-lint cache clean
$ golangci-lint run -v
$  golangci-lint run -v
level=info msg="golangci-lint has version 2.0.2 built with go1.24.1 from 2b224c2c on 2025-03-25T21:36:18Z"
level=info msg="[config_reader] Config search paths: [./ C:\\Users\\AdrianGallagher\\go\\src\\github.com\\thrasher-corp\\gocryptotrader C:\\Users\\AdrianGallagher\\go\\src\\github.com\\thrasher-corp C:\\Users\\AdrianGallagher\\go\\src\\github.com C:\\Users\\AdrianGallagher\\go\\src C:\\Users\\AdrianGallagher\\go C:\\Users\\AdrianGallagher C:\\Users C:\\]"
level=info msg="[config_reader] Used config file .golangci.yml"
level=info msg="maxprocs: Leaving GOMAXPROCS=64: CPU quota undefined"
level=info msg="[goenv] Read go env for 107.1281ms: map[string]string{\"GOCACHE\":\"C:\\\\Users\\\\AdrianGallagher\\\\AppData\\\\Local\\\\go-build\", \"GOROOT\":\"C:\\\\Program Files\\\\Go\"}"
level=info msg="[lintersdb] Active 58 linters: [asciicheck bidichk bodyclose containedctx copyloopvar decorder depguard dogsled dupword durationcheck errcheck errchkjson errname fatcontext forcetypeassert gci gocheckcompilerdirectives gochecksumtype goconst gocritic gofmt gofumpt goimports gomoddirectives gomodguard goprintffuncname gosec govet grouper iface ineffassign intrange makezero mirror misspell nilerr nilnesserr noctx nolintlint nosprintfhostport perfsprint prealloc predeclared reassign revive rowserrcheck sqlclosecheck staticcheck tagalign testableexamples testifylint thelper tparallel unconvert unparam usestdlibvars wastedassign whitespace]"
level=info msg="[loader] Go packages loading at mode 8767 (compiled_files|deps|exports_file|files|types_sizes|imports|name) took 13.3772698s"
level=info msg="[runner/filename_unadjuster] Pre-built 0 adjustments in 110.8382ms"
level=info msg="[linters_context/goanalysis] analyzers took 8m13.1413344s with top 10 stages: gocritic: 5m57.6610603s, goimports: 1m23.7309636s, buildir: 12.9818815s, wastedassign: 5.6575367s, the_only_name: 4.16968s, unparam: 3.2314804s, gosec: 2.8211836s, gofumpt: 2.0454259s, buildssa: 1.1816759s, S1038: 1.1538696s"
level=info msg="[runner/exclusion_paths] Skipped 0 issues by pattern \"third_party$\""
level=info msg="[runner/exclusion_paths] Skipped 0 issues by pattern \"builtin$\""
level=info msg="[runner/exclusion_paths] Skipped 0 issues by pattern \"examples$\""
level=info msg="[runner/exclusion_paths] Skipped 0 issues by pattern \"vendor\""
level=info msg="[runner/exclusion_paths] Skipped 0 issues by pattern \"web\\\\\\\\\""
level=info msg="[runner/exclusion_paths] Skipped 0 issues by pattern \"testdata\""
level=info msg="[runner/exclusion_paths] Skipped 1534 issues by pattern \"database\\\\\\\\models\\\\\\\\\""
level=info msg="[runner/exclusion_rules] Skipped 2 issues by rules: [Text: \"Expect WriteFile permissions to be 0600 or less\", Linters: \"gosec\"]"
level=info msg="[runner/exclusion_rules] Skipped 28 issues by rules: [Text: \"shadow: declaration of \\\"err\\\" shadows declaration at\", Linters: \"govet\"]"
level=info msg="[runner/exclusion_rules] Skipped 0 issues by rules: [Path: \"web\\\\\\\\\", Linters: \"gci, gofmt, gofumpt, goimports\"]"
level=info msg="[runner/exclusion_rules] Skipped 0 issues by rules: [Path: \"third_party$\", Linters: \"gci, gofmt, gofumpt, goimports\"]"
level=info msg="[runner/exclusion_rules] Skipped 0 issues by rules: [Path: \"builtin$\", Linters: \"gci, gofmt, gofumpt, goimports\"]"
level=info msg="[runner/exclusion_rules] Skipped 162 issues by rules: [Text: \"should have a package comment\", Linters: \"revive\"]"
level=info msg="[runner/exclusion_rules] Skipped 0 issues by rules: [Path: \"vendor\", Linters: \"gci, gofmt, gofumpt, goimports\"]"
level=info msg="[runner/exclusion_rules] Skipped 0 issues by rules: [Path: \"testdata\", Linters: \"gci, gofmt, gofumpt, goimports\"]"
level=info msg="[runner/exclusion_rules] Skipped 0 issues by rules: [Path: \"database\\\\\\\\models\\\\\\\\\", Linters: \"gci, gofmt, gofumpt, goimports\"]"
level=info msg="[runner/exclusion_rules] Skipped 0 issues by rules: [Path: \"examples$\", Linters: \"gci, gofmt, gofumpt, goimports\"]"
level=warning msg="[runner/nolint_filter] Found unknown linters in //nolint directives: ifshort"
level=info msg="[runner] Issues before processing: 4228, after processing: 0"
level=info msg="[runner] Processors filtering stat (in/out): path_absoluter: 4228/4228, invalid_issue: 4228/4228, cgo: 4228/4228, filename_unadjuster: 4228/4228, path_relativity: 4228/4228, generated_file_filter: 2694/762, exclusion_rules: 762/465, exclusion_paths: 4228/2694, nolint_filter: 465/0"
level=info msg="[runner] processing took 224.0972ms with stages: nolint_filter: 184.2359ms, generated_file_filter: 28.7338ms, path_relativity: 4.7657ms, exclusion_rules: 3.6786ms, exclusion_paths: 1.596ms, invalid_issue: 544.9µs, cgo: 542.3µs, source_code: 0s, fixer: 0s, path_prettifier: 0s, sort_results: 0s, severity-rules: 0s, path_absoluter: 0s, diff: 0s, max_per_file_from_linter: 0s, path_shortener: 0s, max_from_linter: 0s, filename_unadjuster: 0s, max_same_issues: 0s, uniq_by_line: 0s"
level=info msg="[runner] linters took 16.3985956s with stages: goanalysis_metalinter: 16.1724567s"
0 issues.
level=info msg="File cache stats: 0 entries of total size 0B"
level=info msg="Memory: 303 samples, avg is 1551.1MB, max is 4082.2MB"
level=info msg="Execution took 30.1564123s"

A minimal reproducible example or link to a public repository

func simpleTest() {
	fmt := "meep"
	log.Println(fmt)
}

Validation

  • Yes, I've included all information above (version, config, etc.).

Supporter
@thrasher- thrasher- added the bug Something isn't working label Apr 1, 2025
@boring-cyborg boring-cyborg
Copy link

boring-cyborg bot commented Apr 1, 2025

Hey, thank you for opening your first Issue ! 🙂 If you would like to contribute we have a guide for contributors.

@ldez ldez changed the title gocritic importShadow rule doesn't appear to work for v2.0.2 gocritic importShadow rule doesn't appear to work Apr 1, 2025
@thrasher-
Copy link
Author

thrasher- commented Apr 1, 2025 •
edited by ldez
Loading

Details from running gocritic manually:

$ gocritic check -enable importShadow ./...
./backtester\engine\setup.go:639:60: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/backtester/eventhandlers/strategies/base' package 'base'
./backtester\engine\setup.go:932:49: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/backtester/eventhandlers/strategies/base' package 'base'
./backtester\eventhandlers\strategies\binancecashandcarry\binancecashandcarry.go:128:38: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/backtester/eventhandlers/portfolio/holdings' package 'holdings'
./backtester\eventhandlers\strategies\rsi\rsi.go:178:39: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/backtester/data' package 'data'
./backtester\eventhandlers\strategies\top2bottom2\top2bottom2.go:254:39: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/backtester/data' package 'data'
./backtester\funding\item.go:95:54: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/currency' package 'currency'
./cmd\exchange_template\exchange_template.go:261:3: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/common/file' package 'file'
./cmd\exchange_wrapper_issues\main.go:293:65: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/config' package 'config'
./cmd\exchange_wrapper_issues\main.go:1046:17: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/config' package 'config'
./cmd\gctcli\commands.go:2888:16: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/currency' package 'currency'
./communications\telegram\telegram.go:94:6: importShadow: shadow of imported package 'errors'
./communications\telegram\telegram.go:255:2: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/encoding/json' package 'json'
./database\repository\script\script.go:18:82: importShadow: shadow of imported package 'time'
./database\repository\trade\trade.go:220:16: importShadow: shadow of imported from 'github.com/gofrs/uuid' package 'uuid'
./database\repository\trade\trade.go:236:22: importShadow: shadow of imported from 'github.com/gofrs/uuid' package 'uuid'
./database\repository\trade\trade.go:265:24: importShadow: shadow of imported from 'github.com/gofrs/uuid' package 'uuid'
./engine\order_manager.go:947:36: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/exchanges' package 'exchange'
./engine\portfolio_manager.go:336:48: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/exchanges' package 'exchange'
./exchanges\exchange.go:1013:38: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/exchanges/request' package 'request'
./exchanges\exchange.go:1013:47: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/config' package 'config'
./exchanges\exchange.go:1253:32: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/common/key' package 'key'
./exchanges\exchange.go:1283:28: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/common/key' package 'key'
./exchanges\exchange_test.go:478:2: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/exchanges/futures' package 'futures'
./exchanges\binance\binance.go:1130:69: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/currency' package 'currency'
./exchanges\binance\binance_test.go:2246:2: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/common/key' package 'key'
./exchanges\binanceus\binanceus.go:754:71: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/exchanges/asset' package 'asset'
./exchanges\binanceus\binanceus.go:1589:72: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/currency' package 'currency'
./exchanges\bitfinex\bitfinex.go:403:3: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/currency' package 'currency'
./exchanges\bitfinex\bitfinex.go:501:2: importShadow: shadow of imported package 'url'
./exchanges\bitfinex\bitfinex.go:1366:72: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/currency' package 'currency'
./exchanges\bithumb\bithumb.go:420:82: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/currency' package 'currency'
./exchanges\bithumb\bithumb.go:437:78: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/currency' package 'currency'
./exchanges\bithumb\bithumb.go:457:77: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/currency' package 'currency'
./exchanges\bitmex\bitmex.go:737:53: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/currency' package 'currency'
./exchanges\bitmex\bitmex.go:757:63: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/currency' package 'currency'
./exchanges\bitmex\bitmex.go:799:53: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/currency' package 'currency'
./exchanges\bitmex\bitmex.go:820:56: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/currency' package 'currency'
./exchanges\bitmex\bitmex.go:830:56: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/currency' package 'currency'
./exchanges\bitmex\bitmex_websocket.go:553:64: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/exchanges/stream' package 'stream'
./exchanges\bitstamp\bitstamp.go:157:51: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/currency' package 'currency'
./exchanges\bitstamp\bitstamp.go:171:54: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/currency' package 'currency'
./exchanges\bitstamp\bitstamp.go:185:2: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/exchanges/orderbook' package 'orderbook'
./exchanges\bitstamp\bitstamp.go:450:76: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/currency' package 'currency'
./exchanges\bitstamp\bitstamp.go:472:89: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/currency' package 'currency'
./exchanges\bitstamp\bitstamp.go:502:65: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/common/crypto' package 'crypto'
./exchanges\bitstamp\bitstamp.go:517:46: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/currency' package 'currency'
./exchanges\bitstamp\bitstamp.go:539:80: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/currency' package 'currency'
./exchanges\btse\btse.go:214:54: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/currency' package 'currency'
./exchanges\btse\btse.go:226:57: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/currency' package 'currency'
./exchanges\btse\btse.go:253:54: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/currency' package 'currency'
./exchanges\bybit\bybit.go:1287:56: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/currency' package 'currency'
./exchanges\bybit\bybit.go:1328:57: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/currency' package 'currency'
./exchanges\bybit\bybit.go:2199:66: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/currency' package 'currency'
./exchanges\coinbasepro\coinbasepro.go:539:100: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/currency' package 'currency'
./exchanges\coinbasepro\coinbasepro.go:584:84: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/currency' package 'currency'
./exchanges\coinbasepro\coinbasepro.go:603:79: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/currency' package 'currency'
./exchanges\coinbasepro\coinbasepro.go:619:85: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/currency' package 'currency'
./exchanges\coinbasepro\coinbasepro.go:652:75: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/currency' package 'currency'
./exchanges\coinut\coinut.go:198:54: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/exchanges/asset' package 'asset'
./exchanges\coinut\coinut.go:216:54: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/exchanges/asset' package 'asset'
./exchanges\deribit\deribit.go:2392:81: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/exchanges/nonce' package 'nonce'
./exchanges\deribit\deribit.go:2439:80: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/exchanges/nonce' package 'nonce'
./exchanges\exmo\exmo.go:220:60: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/currency' package 'currency'
./exchanges\exmo\exmo.go:260:50: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/currency' package 'currency'
./exchanges\gateio\gateio_websocket_request_spot.go:26:64: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/exchanges/order' package 'order'
./exchanges\gateio\gateio_test.go:3059:2: importShadow: shadow of imported package 'time'
./exchanges\gemini\gemini.go:336:80: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/currency' package 'currency'
./exchanges\gemini\gemini.go:355:63: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/currency' package 'currency'
./exchanges\hitbtc\hitbtc.go:74:51: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/currency' package 'currency'
./exchanges\hitbtc\hitbtc.go:229:59: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/currency' package 'currency'
./exchanges\hitbtc\hitbtc.go:241:58: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/currency' package 'currency'
./exchanges\hitbtc\hitbtc.go:253:66: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/currency' package 'currency'
./exchanges\hitbtc\hitbtc.go:297:49: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/currency' package 'currency'
./exchanges\hitbtc\hitbtc.go:310:53: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/currency' package 'currency'
./exchanges\hitbtc\hitbtc.go:334:50: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/currency' package 'currency'
./exchanges\hitbtc\hitbtc.go:385:48: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/currency' package 'currency'
./exchanges\hitbtc\hitbtc_wrapper.go:569:57: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/currency' package 'currency'
./exchanges\huobi\huobi.go:643:75: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/currency' package 'currency'
./exchanges\huobi\huobi.go:671:72: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/currency' package 'currency'
./exchanges\huobi\huobi.go:711:80: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/currency' package 'currency'
./exchanges\kline\kline_datastorage.go:21:23: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/database/repository/exchange' package 'exchange'
./exchanges\kraken\kraken.go:433:55: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/currency' package 'currency'
./exchanges\kraken\kraken.go:448:48: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/exchanges/asset' package 'asset'
./exchanges\kraken\kraken.go:463:57: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/currency' package 'currency'
./exchanges\kraken\kraken.go:1003:26: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/currency' package 'currency'
./exchanges\kraken\kraken_futures.go:296:67: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/currency' package 'currency'
./exchanges\kraken\kraken_websocket.go:324:5: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/exchanges/trade' package 'trade'
./exchanges\kucoin\kucoin.go:2819:2: importShadow: shadow of imported package 'fmt'
./exchanges\kucoin\kucoin_futures.go:330:2: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/exchanges/kline' package 'kline'
./exchanges\lbank\lbank.go:116:70: importShadow: shadow of imported package 'time'
./exchanges\mock\recording.go:452:3: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/common/file' package 'file'
./exchanges\okx\okx.go:1373:56: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/currency' package 'currency'
./exchanges\okx\okx_test.go:353:3: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/exchanges/trade' package 'trade'
./exchanges\poloniex\poloniex.go:246:55: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/currency' package 'currency'
./exchanges\poloniex\poloniex.go:367:55: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/currency' package 'currency'
./exchanges\poloniex\poloniex.go:383:81: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/currency' package 'currency'
./exchanges\poloniex\poloniex.go:514:52: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/currency' package 'currency'
./exchanges\poloniex\poloniex.go:605:50: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/currency' package 'currency'
./exchanges\poloniex\poloniex.go:664:57: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/currency' package 'currency'
./exchanges\poloniex\poloniex.go:692:58: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/currency' package 'currency'
./exchanges\poloniex\poloniex.go:715:59: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/currency' package 'currency'
./exchanges\poloniex\poloniex.go:733:61: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/currency' package 'currency'
./exchanges\poloniex\poloniex.go:751:57: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/currency' package 'currency'
./exchanges\stream\websocket.go:749:37: importShadow: shadow of imported package 'url'
./exchanges\stream\websocket_connection.go:281:38: importShadow: shadow of imported package 'url'
./exchanges\stream\websocket_connection.go:296:116: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/exchanges/request' package 'request'
./exchanges\stream\websocket_connection.go:376:27: importShadow: shadow of imported package 'url'
./exchanges\yobit\yobit.go:237:51: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/currency' package 'currency'
./log\logger_rotate.go:64:2: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/common/file' package 'file'
./log\logger_rotate.go:92:2: importShadow: shadow of imported from 'github.com/thrasher-corp/gocryptotrader/common/file' package 'file'

@ldez ldez self-assigned this Apr 1, 2025
@ldez ldez changed the title gocritic importShadow rule doesn't appear to work gocritic: importShadow rule doesn't appear to work Apr 1, 2025
@ldez
Copy link
Member

ldez commented Apr 1, 2025 •
edited
Loading

FYI, the problem is not related to v2, it was already here in v1.

I found the root cause (it only impacts importShadow), now I have to find a fix.

@ldez ldez mentioned this issue Apr 1, 2025
Merged
@thrasher-
Copy link
Author

Thank you @ldez !

@thrasher- thrasher- mentioned this issue Apr 1, 2025
Merged
@ldez ldez closed this as completed in #5673 Apr 1, 2025
@mirecl
Copy link

mirecl commented Apr 30, 2025

FYI, the problem is not related to v2, it was already here in v1.

I found the root cause (it only impacts importShadow), now I have to find a fix.

@ldez, this fix fix: gocritic importshadow checker #5673 only v2?

@ldez
Copy link
Member

ldez commented Apr 30, 2025

Yes, v2 only.

#5300

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ldez ldez

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: gocritic importshadow checker ldez/golangci-lint
3 participants
@thrasher- @ldez @mirecl