Skip to content

Docker image with Go 1.13 #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
troyronda opened this issue Sep 11, 2019 · 2 comments
Closed

Docker image with Go 1.13 #682

troyronda opened this issue Sep 11, 2019 · 2 comments
Labels
area: docker enhancement New feature or improvement

Comments

@troyronda
Copy link

troyronda commented Sep 11, 2019 •
edited
Loading

Version of golangci-lint: 1.18

The docker image for golangci-lint is on Go 1.12 (

golangci-lint/Dockerfile

Line 1 in cad10b2

FROM golang:1.12
)

This can result in some errors when running this docker image against code developed for Go 1.13. In particular:
Is not declared by package errors (typecheck)
@troyronda troyronda mentioned this issue Sep 11, 2019
Closed
@tpounds
Copy link
Contributor

tpounds commented Sep 14, 2019

@jirfag, @troyronda This is fixed by 6ec8ff2 but didn't auto-close since I accidentally annotated the commit with the discarded pull request #683 instead of this issue.

@troyronda
Copy link
Author

Thanks!

@tpounds tpounds added enhancement New feature or improvement area: docker labels Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: docker enhancement New feature or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Dockerfile to use Go 1.13
2 participants
@tpounds @troyronda