[#761] Module jdmn-runtime-api: Add extra test coverage for listeners

Author: opatrascoiu

dmn-runtime-api/src/main/java/com/gs/dmn/runtime/listener/AbstractTraceEventListener.java

@@ -30,11 +30,19 @@ public void startRule(DRGElement element, Rule rule) {
 
     @Override
     public void matchRule(DRGElement element, Rule rule) {
+        if (this.ruleNode == null) {
+            return;
+        }
+
         this.ruleNode.setMatched(true);
     }
 
     @Override
     public void endRule(DRGElement element, Rule rule, Object result) {
+        if (this.ruleNode == null) {
+            return;
+        }
+
         this.ruleNode.setResult(result);
         if (!this.elementNodeStack.empty()) {
             DRGElementNode top = this.elementNodeStack.peek();
@@ -46,6 +54,10 @@ public void endRule(DRGElement element, Rule rule, Object result) {
 
     @Override
     public void matchColumn(Rule rule, int columnIndex, Object result) {
+        if (this.ruleNode == null) {
+            return;
+        }
+
         ColumnNode columnNode = new ColumnNode(columnIndex, result);
         this.ruleNode.addColumnNode(columnNode);
     }

dmn-runtime-api/src/main/java/com/gs/dmn/runtime/listener/LoggingEventListener.java

@@ -23,11 +23,19 @@ public LoggingEventListener(Logger logger) {
 
     @Override
     public void startDRGElement(DRGElement element, Arguments arguments) {
+        if (element == null) {
+            return;
+        }
+
         logger.debug("Start {} '{}' with inputs '{}'", element.getElementKind().getDisplayName(), element.getName(), arguments);
     }
 
     @Override
     public void endDRGElement(DRGElement element, Arguments arguments, Object output, long duration) {
+        if (element == null) {
+            return;
+        }
+
         logger.debug("End {} '{}' with output '{}' in {}ms", element.getElementKind().getDisplayName(), element.getName(), output, duration);
     }
 
@@ -41,6 +49,10 @@ public void matchRule(DRGElement element, Rule rule) {
 
     @Override
     public void endRule(DRGElement element, Rule rule, Object output) {
+        if (rule == null) {
+            return;
+        }
+
         logger.debug("Rule {} fired with output '{}'", rule.getIndex(), output);
     }
 

dmn-runtime-api/src/test/java/com/gs/dmn/runtime/listener/AbstractListenerTest.java

@@ -0,0 +1,40 @@
+package com.gs.dmn.runtime.listener;
+
+import com.gs.dmn.runtime.annotation.DRGElementKind;
+import com.gs.dmn.runtime.annotation.ExpressionKind;
+import com.gs.dmn.runtime.annotation.HitPolicy;
+import org.junit.jupiter.api.Test;
+
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
+public abstract class AbstractListenerTest {
+    protected EventListener listener;
+
+    @Test
+    public void testEvents() {
+        DRGElement element = new DRGElement("namespace", "name", "label", DRGElementKind.DECISION, ExpressionKind.LITERAL_EXPRESSION, HitPolicy.UNIQUE, 5);
+        Rule rule = new Rule(1, "annotation");
+        Arguments arguments = new Arguments();
+
+        listener.startDRGElement(element, arguments);
+        listener.endDRGElement(element, arguments, null, 0);
+        listener.startRule(element, rule);
+        listener.matchRule(element, rule);
+        listener.endRule(element, rule, null);
+        listener.matchColumn(rule, 1, null);
+
+        assertTrue(true);
+    }
+
+    @Test
+    public void testEventsWithNull() {
+        listener.startDRGElement(null, null);
+        listener.endDRGElement(null, null, null, 0);
+        listener.startRule(null, null);
+        listener.matchRule(null, null);
+        listener.endRule(null, null, null);
+        listener.matchColumn(null, 0, null);
+
+        assertTrue(true);
+    }
+}

dmn-runtime-api/src/test/java/com/gs/dmn/runtime/listener/CompositeListenerTest.java

@@ -12,46 +12,11 @@
  */
 package com.gs.dmn.runtime.listener;
 
-import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.BeforeEach;
 
-import static org.junit.jupiter.api.Assertions.assertTrue;
-
-public class CompositeListenerTest {
-    private final EventListener listener = new CompositeListener();
-
-    @Test
-    public void testStartDRGElement() {
-        listener.startDRGElement(null, null);
-        assertTrue(true);
-    }
-
-    @Test
-    public void testEndDRGElement() {
-        listener.endDRGElement(null, null, null, 0);
-        assertTrue(true);
-    }
-
-    @Test
-    public void testStartRule() {
-        listener.startRule(null, null);
-        assertTrue(true);
-    }
-
-    @Test
-    public void testMatchRule() {
-        listener.matchRule(null, null);
-        assertTrue(true);
-    }
-
-    @Test
-    public void testEndRule() {
-        listener.endRule(null, null, null);
-        assertTrue(true);
-    }
-
-    @Test
-    public void testMatchColumn() {
-        listener.matchColumn(null, 0, null);
-        assertTrue(true);
+public class CompositeListenerTest extends AbstractListenerTest {
+    @BeforeEach
+    void setUp() {
+        this.listener = new CompositeListener();
     }
 }

dmn-runtime-api/src/test/java/com/gs/dmn/runtime/listener/LoggingEventListenerTest.java

@@ -0,0 +1,26 @@
+/*
+ * Copyright 2016 Goldman Sachs.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License.
+ *
+ * You may obtain a copy of the License at
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations under the License.
+ */
+package com.gs.dmn.runtime.listener;
+
+import org.junit.jupiter.api.BeforeEach;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class LoggingEventListenerTest extends AbstractListenerTest {
+    protected static final Logger LOGGER = LoggerFactory.getLogger(LoggingEventListenerTest.class);
+
+    @BeforeEach
+    void setUp() {
+        this.listener = new LoggingEventListener(LOGGER);
+    }
+}

dmn-runtime-api/src/test/java/com/gs/dmn/runtime/listener/NopListenerTest.java

@@ -0,0 +1,22 @@
+/*
+ * Copyright 2016 Goldman Sachs.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License.
+ *
+ * You may obtain a copy of the License at
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations under the License.
+ */
+package com.gs.dmn.runtime.listener;
+
+import org.junit.jupiter.api.BeforeEach;
+
+public class NopListenerTest extends AbstractListenerTest {
+    @BeforeEach
+    void setUp() {
+        this.listener = new NopEventListener();
+    }
+}

dmn-runtime-api/src/test/java/com/gs/dmn/runtime/listener/PostorderTraceEventListenerTest.java

@@ -0,0 +1,22 @@
+/*
+ * Copyright 2016 Goldman Sachs.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License.
+ *
+ * You may obtain a copy of the License at
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations under the License.
+ */
+package com.gs.dmn.runtime.listener;
+
+import org.junit.jupiter.api.BeforeEach;
+
+class PostorderTraceEventListenerTest extends AbstractListenerTest {
+    @BeforeEach
+    void setUp() {
+        this.listener = new PostorderTraceEventListener();
+    }
+}

dmn-runtime-api/src/test/java/com/gs/dmn/runtime/listener/TreeTraceEventListenerTest.java

@@ -0,0 +1,22 @@
+/*
+ * Copyright 2016 Goldman Sachs.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License.
+ *
+ * You may obtain a copy of the License at
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations under the License.
+ */
+package com.gs.dmn.runtime.listener;
+
+import org.junit.jupiter.api.BeforeEach;
+
+class TreeTraceEventListenerTest extends AbstractListenerTest {
+    @BeforeEach
+    void setUp() {
+        this.listener = new TreeTraceEventListener();
+    }
+}