[#755] Improve error handling for missing variable declaration

Author: opatrascoiu

dmn-core/src/main/java/com/gs/dmn/feel/analysis/semantics/FEELSemanticVisitor.java

@@ -1045,24 +1045,28 @@ public Element<Type> visit(Name<Type> element, DMNContext context) {
     }
 
     private void deriveType(NamedExpression<Type> element, DMNContext context, String name) {
-        Type type;
         // Lookup for variables
         Declaration declaration = context.lookupVariableDeclaration(name);
         if (declaration instanceof VariableDeclaration) {
-            type = declaration.getType();
+            Type type = declaration.getType();
             element.setType(type);
-        } else {
-            // Lookup for functions
-            List<Declaration> declarations = context.lookupFunctionDeclaration(name);
-            if (declarations != null && !declarations.isEmpty()) {
-                if (declarations.size() == 1) {
-                    declaration = declarations.get(0);
-                    type = declaration.getType();
-                } else {
-                    type = new BuiltinOverloadedFunctionType(declarations);
-                }
-                element.setType(type);
+            return;
+        }
+        // Lookup for functions
+        List<Declaration> declarations = context.lookupFunctionDeclaration(name);
+        if (declarations != null && !declarations.isEmpty()) {
+            Type type;
+            if (declarations.size() == 1) {
+                declaration = declarations.get(0);
+                type = declaration.getType();
+            } else {
+                type = new BuiltinOverloadedFunctionType(declarations);
             }
+            element.setType(type);
+            return;
+        }
+        if (this.dmnTransformer.isStrongTyping()) {
+            errorHandler.reportError(String.format("Cannot find declaration for '%s'", name));
         }
     }
 

dmn-core/src/test/java/com/gs/dmn/runtime/interpreter/AbstractCL3DMNInterpreterTest.java

@@ -622,6 +622,11 @@ public void test_15_cl3_0068_feel_equality() {
         doFolderTest("1.5", "0068-feel-equality", new Pair<>("strongTyping", "false") );
     }
 
+    @Test
+    public void test_15_cl3_0069_feel_list() {
+        doFolderTest("1.5", "0069-feel-list", new Pair<>("strongTyping", "false") );
+    }
+
     @Test
     public void test_15_cl3_0072_feel_in() {
         doFolderTest("1.5", "0072-feel-in", new Pair<>("strongTyping", "false") );