Skip to content

Commit 1deebd3

Browse files
authored
Update to Node 24 (#398)
1 parent c0f6160 commit 1deebd3

File tree

10 files changed

+38
-53
lines changed

10 files changed

+38
-53
lines changed

.github/actionlint.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
paths:
2+
'**/*.yml':
3+
ignore:
4+
# https://github.com/rhysd/actionlint/issues/559
5+
- 'invalid runner name "node24"'

.github/workflows/integration.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ jobs:
3737
- name: 'npm build'
3838
run: 'npm ci && npm run build'
3939

40-
- uses: 'google-github-actions/auth@v2' # ratchet:exclude
40+
- uses: 'google-github-actions/auth@v3' # ratchet:exclude
4141
with:
4242
workload_identity_provider: '${{ vars.WIF_PROVIDER_NAME }}'
4343
service_account: '${{ vars.SERVICE_ACCOUNT_EMAIL }}'

.github/workflows/unit.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ jobs:
4949
# Only authenticate if this is a full CI run.
5050
- if: |-
5151
${{ github.event_name == 'push' || github.repository == github.event.pull_request.head.repo.full_name }}
52-
uses: 'google-github-actions/auth@v2' # ratchet:exclude
52+
uses: 'google-github-actions/auth@v3' # ratchet:exclude
5353
with:
5454
workload_identity_provider: '${{ vars.WIF_PROVIDER_NAME }}'
5555
service_account: '${{ vars.SERVICE_ACCOUNT_EMAIL }}'

README.md

Lines changed: 16 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,10 @@ support](https://cloud.google.com/support).**
1717
blobs to the specified bucket. See the [Authorization](#authorization)
1818
section below for more information.
1919

20-
- This action runs using Node 16. If you are using self-hosted GitHub Actions
21-
runners, you must use runner version [2.285.0](https://github.com/actions/virtual-environments)
22-
or newer.
20+
- This action runs using Node 24. If you are using self-hosted GitHub Actions
21+
runners, you must use a [runner
22+
version](https://github.com/actions/virtual-environments) that supports this
23+
version or later.
2324

2425
## Usage
2526

@@ -43,13 +44,13 @@ jobs:
4344
uses: 'actions/checkout@v4'
4445

4546
- id: 'auth'
46-
uses: 'google-github-actions/auth@v2'
47+
uses: 'google-github-actions/auth@v3'
4748
with:
4849
workload_identity_provider: 'projects/123456789/locations/global/workloadIdentityPools/my-pool/providers/my-provider'
4950
service_account: '[email protected]'
5051

5152
- id: 'upload-file'
52-
uses: 'google-github-actions/upload-cloud-storage@v2'
53+
uses: 'google-github-actions/upload-cloud-storage@v3'
5354
with:
5455
path: '/path/to/file'
5556
destination: 'bucket-name'
@@ -77,13 +78,13 @@ jobs:
7778
uses: 'actions/checkout@v4'
7879
7980
- id: 'auth'
80-
uses: 'google-github-actions/auth@v2'
81+
uses: 'google-github-actions/auth@v3'
8182
with:
8283
workload_identity_provider: 'projects/123456789/locations/global/workloadIdentityPools/my-pool/providers/my-provider'
8384
service_account: '[email protected]'
8485
8586
- id: 'upload-folder'
86-
uses: 'google-github-actions/upload-cloud-storage@v2'
87+
uses: 'google-github-actions/upload-cloud-storage@v3'
8788
with:
8889
path: '/path/to/folder'
8990
destination: 'bucket-name'
@@ -113,7 +114,7 @@ With default configuration
113114

114115
```yaml
115116
- id: 'upload-files'
116-
uses: 'google-github-actions/upload-cloud-storage@v2'
117+
uses: 'google-github-actions/upload-cloud-storage@v3'
117118
with:
118119
path: 'myfolder'
119120
destination: 'bucket-name'
@@ -125,7 +126,7 @@ Optionally, you can also specify a prefix in destination.
125126

126127
```yaml
127128
- id: 'upload-files'
128-
uses: 'google-github-actions/upload-cloud-storage@v2'
129+
uses: 'google-github-actions/upload-cloud-storage@v3'
129130
with:
130131
path: 'myfolder'
131132
destination: 'bucket-name/myprefix'
@@ -140,7 +141,7 @@ Setting `parent` to false will omit `path` when uploading to bucket.
140141

141142
```yaml
142143
- id: 'upload-files'
143-
uses: 'google-github-actions/upload-cloud-storage@v2'
144+
uses: 'google-github-actions/upload-cloud-storage@v3'
144145
with:
145146
path: 'myfolder'
146147
destination: 'bucket-name'
@@ -155,7 +156,7 @@ Optionally, you can also specify a prefix in destination.
155156

156157
```yaml
157158
- id: 'upload-files'
158-
uses: 'google-github-actions/upload-cloud-storage@v2'
159+
uses: 'google-github-actions/upload-cloud-storage@v3'
159160
with:
160161
path: 'myfolder'
161162
destination: 'bucket-name/myprefix'
@@ -170,7 +171,7 @@ You can specify a glob pattern like
170171

171172
```yaml
172173
- id: 'upload-files'
173-
uses: 'google-github-actions/upload-cloud-storage@v2'
174+
uses: 'google-github-actions/upload-cloud-storage@v3'
174175
with:
175176
path: 'myfolder'
176177
destination: 'bucket-name'
@@ -348,12 +349,12 @@ jobs:
348349
349350
steps:
350351
- id: 'auth'
351-
uses: 'google-github-actions/auth@v2'
352+
uses: 'google-github-actions/auth@v3'
352353
with:
353354
workload_identity_provider: 'projects/123456789/locations/global/workloadIdentityPools/my-pool/providers/my-provider'
354355
service_account: '[email protected]'
355356
356-
- uses: 'google-github-actions/upload-cloud-storage@v2'
357+
- uses: 'google-github-actions/upload-cloud-storage@v3'
357358
```
358359

359360
### Via Application Default Credentials
@@ -368,7 +369,7 @@ jobs:
368369
job_id:
369370
steps:
370371
- id: 'upload-file'
371-
uses: 'google-github-actions/upload-cloud-storage@v2'
372+
uses: 'google-github-actions/upload-cloud-storage@v3'
372373
```
373374

374375
The action will automatically detect and use the Application Default

action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -195,5 +195,5 @@ branding:
195195

196196

197197
runs:
198-
using: 'node20'
198+
using: 'node24'
199199
main: 'dist/main/index.js'

bin/runTests.sh

Lines changed: 0 additions & 21 deletions
This file was deleted.

dist/main/index.js

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package-lock.json

Lines changed: 7 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,10 @@
88
"docs": "./node_modules/.bin/actions-gen-readme",
99
"lint": "eslint .",
1010
"format": "eslint . --fix",
11-
"test": "bash ./bin/runTests.sh"
11+
"test": "node --require ts-node/register --test-reporter spec --test tests/**/*.test.ts"
1212
},
1313
"engines": {
14-
"node": ">= 20.x",
14+
"node": ">= 24.x",
1515
"npm": ">= 11.x"
1616
},
1717
"repository": {
@@ -30,7 +30,7 @@
3030
"dependencies": {
3131
"@actions/core": "^1.11.1",
3232
"@google-cloud/storage": "^7.17.0",
33-
"@google-github-actions/actions-utils": "^0.8.10",
33+
"@google-github-actions/actions-utils": "^1.0.1",
3434
"fast-glob": "^3.3.3",
3535
"ignore": "^7.0.5"
3636
},

src/main.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ const NO_FILES_WARNING =
4242
`\n` +
4343
` - uses: 'actions/checkout@v4'\n` +
4444
` # ...\n` +
45-
` - uses: 'google-github-actions/upload-cloud-storage@v2'\n` +
45+
` - uses: 'google-github-actions/upload-cloud-storage@v3'\n` +
4646
`\n` +
4747
`Check that the "path" points to a valid destination on disk, relative to ` +
4848
`the GitHub Workspace. Make sure your files are not being ignored via a ` +

0 commit comments

Comments
 (0)