Skip to content

CI: Check PRs for go mod tidy #2730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bobbypage opened this issue Nov 13, 2020 · 0 comments · Fixed by #2738
Closed

CI: Check PRs for go mod tidy #2730

bobbypage opened this issue Nov 13, 2020 · 0 comments · Fixed by #2738

Comments

@bobbypage
Copy link
Collaborator

bobbypage commented Nov 13, 2020 •
edited
Loading

Need to run go mod tidy on both the main module as well as on cmd/module and check if there are any changes as part of CI. If there are any changes, we should fail CI on the PR ensuring go mod tidy is always run if needed.
@bobbypage bobbypage changed the title CI: Check PRs for go mod tidy CI: Check PRs for go mod tidy Nov 13, 2020
This was referenced Nov 13, 2020
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check go mod tidy as part of presubmit and CI bobbypage/cadvisor
1 participant
@bobbypage