Changes for PR

DenisKarch · DenisKarch · commit fb1f3cece56c · 2019-03-12T09:19:36.000-07:00
Added back newline that was deleted by mistake
Added link to RSAES-OAEP issue in golang/go
diff --git a/x509/x509.go b/x509/x509.go
@@ -1329,14 +1329,15 @@ func parsePublicKey(algo PublicKeyAlgorithm, keyData *publicKeyInfo, nfe *NonFat
 		if len(rest) != 0 {
 			return nil, errors.New("x509: trailing data after RSA public key")
 		}
+
 		if p.N.Sign() <= 0 {
 			nfe.AddError(errors.New("x509: RSA modulus is not a positive number"))
 		}
 		if p.E <= 0 {
 			return nil, errors.New("x509: RSA public exponent is not a positive number")
 		}
 
-		// TODO(dkarch): Update to return the parameters once crypto/x509 has come up with permanent solution
+		// TODO(dkarch): Update to return the parameters once crypto/x509 has come up with permanent solution (https://github.com/golang/go/issues/30416)
 		pub := &rsa.PublicKey{
 			E: p.E,
 			N: p.N,

Original file line number	Diff line number	Diff line change
`@@ -1329,14 +1329,15 @@ func parsePublicKey(algo PublicKeyAlgorithm, keyData publicKeyInfo, nfe NonFat`
`1329`	`1329`	`if len(rest) != 0 {`
`1330`	`1330`	`return nil, errors.New("x509: trailing data after RSA public key")`
`1331`	`1331`	`}`
	`1332`	`+`
`1332`	`1333`	`if p.N.Sign() <= 0 {`
`1333`	`1334`	`nfe.AddError(errors.New("x509: RSA modulus is not a positive number"))`
`1334`	`1335`	`}`
`1335`	`1336`	`if p.E <= 0 {`
`1336`	`1337`	`return nil, errors.New("x509: RSA public exponent is not a positive number")`
`1337`	`1338`	`}`
`1338`	`1339`
`1339`		`- // TODO(dkarch): Update to return the parameters once crypto/x509 has come up with permanent solution`
	`1340`	`+ // TODO(dkarch): Update to return the parameters once crypto/x509 has come up with permanent solution (https://github.com/golang/go/issues/30416)`
`1340`	`1341`	`pub := &rsa.PublicKey{`
`1341`	`1342`	`E: p.E,`
`1342`	`1343`	`N: p.N,`