Skip to content
This repository was archived by the owner on Jan 9, 2023. It is now read-only.

Commit c53cb4d

Browse files
stereotype441domesticmouse
authored andcommitted
Remove workarounds for dart-lang/language#1785.
PiperOrigin-RevId: 415311843
1 parent f13746c commit c53cb4d

File tree

3 files changed

+3
-8
lines changed

3 files changed

+3
-8
lines changed

charts_common/lib/src/chart/bar/base_bar_renderer.dart

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -398,10 +398,7 @@ abstract class BaseBarRenderer<D, R extends BaseBarRendererElement,
398398
final domainValue = domainFn(barIndex);
399399

400400
final measureValue = measureFn(barIndex);
401-
// TODO: remove this explicit `bool` type when no longer
402-
// needed to work around
403-
// https://github.com/dart-lang/language/issues/1785
404-
final bool measureIsNull = measureValue == null;
401+
final measureIsNull = measureValue == null;
405402
final measureIsNegative = !measureIsNull && measureValue < 0;
406403

407404
// Each bar should be stored in barStackMap in a structure that mirrors

charts_common/lib/src/chart/common/behavior/selection/select_nearest.dart

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -245,9 +245,7 @@ class SelectNearest<D> implements ChartBehavior<D> {
245245
final domainFn = series.domainFn;
246246
final domainLowerBoundFn = series.domainLowerBoundFn;
247247
final domainUpperBoundFn = series.domainUpperBoundFn;
248-
// TODO: remove this explicit `bool` type when no longer
249-
// needed to work around https://github.com/dart-lang/language/issues/1785
250-
final bool testBounds =
248+
final testBounds =
251249
domainLowerBoundFn != null && domainUpperBoundFn != null;
252250

253251
for (var i = 0; i < series.data.length; i++) {

charts_common/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ description: A common library for charting packages.
44
homepage: https://github.com/google/charts
55

66
environment:
7-
sdk: '>=2.12.0 <3.0.0'
7+
sdk: '>=2.15.0 <3.0.0'
88

99
dependencies:
1010
collection: ^1.14.5

0 commit comments

Comments
 (0)