Skip to content

Fix _text_ in Koran translation. #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jooyunghan opened this issue Feb 17, 2023 · 6 comments
Open

Fix _text_ in Koran translation. #432

jooyunghan opened this issue Feb 17, 2023 · 6 comments
Assignees

Comments

@jooyunghan
Copy link
Collaborator

jooyunghan commented Feb 17, 2023

_text_ doesn't work when it's in the middle of a word: e.g. Abc_def_

In Korean translation, there's so many cases due to postposition (-이/가, -을/를, -은/는..) in Korean language system.

Note *text* works: e.g. Abcdef.

Ideas:

  • use *text* instead
  • fix MD parser to support _text_

Btw, in Korean, we don't use italic to emphasize in general. Instead, we use bold or 'quote'. I'd like to avoid italic in Korean translation.

@mgeisler
Copy link
Collaborator

  • use *text* instead
  • fix MD parser to support _text_

Are you suggesting updating the English text to use * instead of _? I think we're mostly using * right now, but it turns out that we have guidelines for this and they ask us to use _ instead: https://developers.google.com/style/text-formatting.

My plan is to reformat everything to be consistent when #318 is fixed. I'm hoping to find a volunteer to fix that issue before I do it myself 😄

Btw, in Korean, we don't use italic to emphasize in general. Instead, we use bold or 'quote'. I'd like to avoid italic in Korean translation.

Okay, I love that you take that into account in the translation! You should not feel tied to the English source text (and it's formatting) here. So please translate *text* into **text** as you see fit in the Korean translation.

@jooyunghan
Copy link
Collaborator Author

I thought only fixing in the Korean translation 😃

@mgeisler
Copy link
Collaborator

I thought only fixing in the Korean translation smiley

Okay, sounds great then!

@jooyunghan
Copy link
Collaborator Author

@jooyunghan
Copy link
Collaborator Author

@mgeisler
Copy link
Collaborator

Hi @jooyunghan, is this still something that we need to fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants