Methods inside local classes are not javadoccable.

PiperOrigin-RevId: 886936126

Author: kluever

core/src/main/java/com/google/errorprone/bugpatterns/javadoc/Utils.java

@@ -40,7 +40,10 @@
 import com.sun.source.util.TreePath;
 import com.sun.source.util.TreePathScanner;
 import com.sun.tools.javac.api.JavacTrees;
+import com.sun.tools.javac.code.Symbol;
+import com.sun.tools.javac.code.Symbol.ClassSymbol;
 import com.sun.tools.javac.code.Symbol.MethodSymbol;
+import com.sun.tools.javac.code.Symbol.PackageSymbol;
 import com.sun.tools.javac.tree.DCTree.DCDocComment;
 import com.sun.tools.javac.tree.DocCommentTable;
 import com.sun.tools.javac.tree.JCTree;
@@ -159,24 +162,31 @@ public Void visitPackage(PackageTree packageTree, Void unused) {
 
       @Override
       public Void visitClass(ClassTree classTree, Void unused) {
-        if (!(getSymbol(classTree).owner instanceof MethodSymbol)) {
+        Symbol owner = getSymbol(classTree).owner;
+        if (owner instanceof PackageSymbol || owner instanceof ClassSymbol) {
           javadoccablePositions.put(ASTHelpers.getStartPosition(classTree), getCurrentPath());
         }
         return super.visitClass(classTree, null);
       }
 
       @Override
       public Void visitMethod(MethodTree methodTree, Void unused) {
-        if (!ASTHelpers.isGeneratedConstructor(methodTree)) {
+        Symbol owner = getSymbol(methodTree).owner;
+        if (!ASTHelpers.isGeneratedConstructor(methodTree)
+            && owner instanceof ClassSymbol
+            && !isLocalOrAnonymousClass(owner)) {
           javadoccablePositions.put(ASTHelpers.getStartPosition(methodTree), getCurrentPath());
         }
         return super.visitMethod(methodTree, null);
       }
 
       @Override
       public Void visitVariable(VariableTree variableTree, Void unused) {
-        ElementKind kind = getSymbol(variableTree).getKind();
-        if (kind == ElementKind.FIELD && !ASTHelpers.isRecord(getSymbol(variableTree))) {
+        Symbol symbol = getSymbol(variableTree);
+        ElementKind kind = symbol.getKind();
+        if (kind == ElementKind.FIELD
+            && !ASTHelpers.isRecord(symbol)
+            && !isLocalOrAnonymousClass(symbol.owner)) {
           javadoccablePositions.put(ASTHelpers.getStartPosition(variableTree), getCurrentPath());
         }
         // For enum constants, skip past the desugared class declaration.
@@ -202,5 +212,9 @@ public Void visitModule(ModuleTree moduleTree, Void unused) {
     return ImmutableMap.copyOf(javadoccablePositions);
   }
 
+  private static boolean isLocalOrAnonymousClass(Symbol sym) {
+    return sym.isAnonymous() || sym.owner instanceof MethodSymbol;
+  }
+
   private Utils() {}
 }

core/src/test/java/com/google/errorprone/bugpatterns/javadoc/AlmostJavadocTest.java

@@ -277,8 +277,6 @@ public void nonJavadoccablePositionMethod() {
             public class Test {
               void foo() {
                 class Foo {
-                  // TODO(kak): this shouldn't fire here!
-                  // BUG: Diagnostic contains: AlmostJavadoc
                   /* Foo {@link Test}. */
                   void bar() {}
                 }

core/src/test/java/com/google/errorprone/bugpatterns/javadoc/NotJavadocTest.java

@@ -74,14 +74,14 @@ class A {}
 
   @Test
   public void nestedClassWithMethod() {
-    // TODO(kak): we should also fix the "javadocs" on the method inside the local class
     compilationHelper
         .addSourceLines(
             "Test.java",
             """
             class Test {
               void test() {
                 class A {
+                  // BUG: Diagnostic contains: local class
                   /** Not Javadoc. */
                   void method() {}
                 }
@@ -124,15 +124,14 @@ void method() {}
               }
             }
             """)
-        // TODO(kak): we should also fix the "javadocs" on the method inside the local class
         .addOutputLines(
             "Test.java",
             """
             class Test {
               void test() {
                 /* Not Javadoc. */
                 class A {
-                  /** Not Javadoc. */
+                  /* Not Javadoc. */
                   void method() {}
                 }
               }