Skip to content

Commit 162544b

Browse files
cpovirkGoogle Java Core Libraries
authored andcommitted
Make some private classes final.
RELNOTES=n/a PiperOrigin-RevId: 784189028
1 parent b18c227 commit 162544b

File tree

126 files changed

+247
-227
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

126 files changed

+247
-227
lines changed

android/guava-testlib/src/com/google/common/collect/testing/Helpers.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -251,7 +251,7 @@ public void remove() {
251251
return iterator.next();
252252
}
253253

254-
private static class EntryComparator<K extends @Nullable Object, V extends @Nullable Object>
254+
private static final class EntryComparator<K extends @Nullable Object, V extends @Nullable Object>
255255
implements Comparator<Entry<K, V>> {
256256
final @Nullable Comparator<? super K> keyComparator;
257257

android/guava-testlib/src/com/google/common/collect/testing/MapTestSuiteBuilder.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,7 @@ public static Set<Feature<?>> computeCommonDerivedCollectionFeatures(
227227
return derivedFeatures;
228228
}
229229

230-
private static class ReserializedMapGenerator<K, V> implements TestMapGenerator<K, V> {
230+
private static final class ReserializedMapGenerator<K, V> implements TestMapGenerator<K, V> {
231231
private final OneSizeTestContainerGenerator<Map<K, V>, Entry<K, V>> mapGenerator;
232232

233233
ReserializedMapGenerator(OneSizeTestContainerGenerator<Map<K, V>, Entry<K, V>> mapGenerator) {

android/guava-testlib/src/com/google/common/collect/testing/SampleElements.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ public Colliders() {
140140
}
141141
}
142142

143-
private static class Collider {
143+
private static final class Collider {
144144
final int value;
145145

146146
Collider(int value) {

android/guava-testlib/src/com/google/common/collect/testing/google/BiMapInverseTester.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ public void testInverseSerialization() {
5959
assertSame(copy.forward, copy.backward.inverse());
6060
}
6161

62-
private static class BiMapPair<K, V> implements Serializable {
62+
private static final class BiMapPair<K, V> implements Serializable {
6363
final BiMap<K, V> forward;
6464
final BiMap<V, K> backward;
6565

android/guava-testlib/src/com/google/common/collect/testing/google/ListMultimapTestSuiteBuilder.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ Set<Feature<?>> computeMultimapGetFeatures(Set<Feature<?>> multimapFeatures) {
112112
return derivedFeatures;
113113
}
114114

115-
private static class MultimapGetGenerator<K, V>
115+
private static final class MultimapGetGenerator<K, V>
116116
extends MultimapTestSuiteBuilder.MultimapGetGenerator<K, V, ListMultimap<K, V>>
117117
implements TestListGenerator<V> {
118118
MultimapGetGenerator(
@@ -126,7 +126,7 @@ public List<V> create(Object... elements) {
126126
}
127127
}
128128

129-
private static class MultimapAsMapGetGenerator<K, V>
129+
private static final class MultimapAsMapGetGenerator<K, V>
130130
extends MultimapTestSuiteBuilder.MultimapAsMapGetGenerator<K, V, ListMultimap<K, V>>
131131
implements TestListGenerator<V> {
132132
MultimapAsMapGetGenerator(

android/guava-testlib/src/com/google/common/collect/testing/google/MultimapTestSuiteBuilder.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -310,7 +310,7 @@ Set<Feature<?>> computeMultimapAsMapGetFeatures(Set<Feature<?>> multimapFeatures
310310
return derivedFeatures;
311311
}
312312

313-
private static class AsMapGenerator<K, V, M extends Multimap<K, V>>
313+
private static final class AsMapGenerator<K, V, M extends Multimap<K, V>>
314314
implements TestMapGenerator<K, Collection<V>>, DerivedGenerator {
315315
private final OneSizeTestContainerGenerator<M, Entry<K, V>> multimapGenerator;
316316

@@ -634,7 +634,7 @@ public Collection<V> create(Object... elements) {
634634
}
635635
}
636636

637-
private static class ReserializedMultimapGenerator<K, V, M extends Multimap<K, V>>
637+
private static final class ReserializedMultimapGenerator<K, V, M extends Multimap<K, V>>
638638
implements TestMultimapGenerator<K, V, M> {
639639
private final OneSizeTestContainerGenerator<M, Entry<K, V>> multimapGenerator;
640640

android/guava-testlib/src/com/google/common/collect/testing/google/SetMultimapTestSuiteBuilder.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ TestSuite computeEntriesTestSuite(
107107
.createTestSuite();
108108
}
109109

110-
private static class EntriesGenerator<K, V>
110+
private static final class EntriesGenerator<K, V>
111111
extends MultimapTestSuiteBuilder.EntriesGenerator<K, V, SetMultimap<K, V>>
112112
implements TestSetGenerator<Entry<K, V>> {
113113

android/guava-testlib/src/com/google/common/testing/ClassSanityTester.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -265,7 +265,7 @@ private boolean hasInstanceMethodToTestNulls(Class<?> c, Visibility visibility)
265265
* <pre>
266266
* public class FooTest {
267267
*
268-
* private static class FooFactoryForTest {
268+
* private static final class FooFactoryForTest {
269269
* public static Foo create(String a, String b, int c, boolean d) {
270270
* return Foo.builder()
271271
* .setA(a)

android/guava-testlib/src/com/google/common/util/concurrent/testing/TestingExecutors.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ public ListenableScheduledFuture<?> scheduleWithFixedDelay(
151151
return NeverScheduledFuture.create();
152152
}
153153

154-
private static class NeverScheduledFuture<V> extends AbstractFuture<V>
154+
private static final class NeverScheduledFuture<V> extends AbstractFuture<V>
155155
implements ListenableScheduledFuture<V> {
156156

157157
static <V> NeverScheduledFuture<V> create() {

android/guava/src/com/google/common/base/Functions.java

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ public String toString() {
149149
return new ForMapWithDefault<>(map, defaultValue);
150150
}
151151

152-
private static class FunctionForMapNoDefault<
152+
private static final class FunctionForMapNoDefault<
153153
K extends @Nullable Object, V extends @Nullable Object>
154154
implements Function<K, V>, Serializable {
155155
final Map<K, V> map;
@@ -189,7 +189,8 @@ public String toString() {
189189
@GwtIncompatible @J2ktIncompatible private static final long serialVersionUID = 0;
190190
}
191191

192-
private static class ForMapWithDefault<K extends @Nullable Object, V extends @Nullable Object>
192+
private static final class ForMapWithDefault<
193+
K extends @Nullable Object, V extends @Nullable Object>
193194
implements Function<K, V>, Serializable {
194195
final Map<K, ? extends V> map;
195196
@ParametricNullness final V defaultValue;
@@ -250,7 +251,7 @@ Function<A, C> compose(Function<B, C> g, Function<A, ? extends B> f) {
250251
return new FunctionComposition<>(g, f);
251252
}
252253

253-
private static class FunctionComposition<
254+
private static final class FunctionComposition<
254255
A extends @Nullable Object, B extends @Nullable Object, C extends @Nullable Object>
255256
implements Function<A, C>, Serializable {
256257
private final Function<B, C> g;
@@ -308,7 +309,7 @@ public String toString() {
308309
/**
309310
* @see Functions#forPredicate
310311
*/
311-
private static class PredicateFunction<T extends @Nullable Object>
312+
private static final class PredicateFunction<T extends @Nullable Object>
312313
implements Function<T, Boolean>, Serializable {
313314
private final Predicate<T> predicate;
314315

@@ -358,7 +359,7 @@ public String toString() {
358359
return new ConstantFunction<>(value);
359360
}
360361

361-
private static class ConstantFunction<E extends @Nullable Object>
362+
private static final class ConstantFunction<E extends @Nullable Object>
362363
implements Function<@Nullable Object, E>, Serializable {
363364
@ParametricNullness private final E value;
364365

@@ -411,7 +412,8 @@ public String toString() {
411412
/**
412413
* @see Functions#forSupplier
413414
*/
414-
private static class SupplierFunction<F extends @Nullable Object, T extends @Nullable Object>
415+
private static final class SupplierFunction<
416+
F extends @Nullable Object, T extends @Nullable Object>
415417
implements Function<F, T>, Serializable {
416418

417419
private final Supplier<T> supplier;

0 commit comments

Comments
 (0)