Skip to content

Use xcodebuild for ios unit tests #787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 6, 2023

Conversation

jjliu15
Copy link
Collaborator

@jjliu15 jjliu15 commented Mar 2, 2023

Description

Update github unit test actions to use xcodebuild test instead of pod lib lint to run iOS unit tests.
This is necessary as part of supporting the register webview API,, since we need to add s.dependency 'webview_flutter_wkwebview' to our podspec. This only builds in iOS apps that have the flutter podfile macros, and not in pod lib lint.

Also fixes the google_mobile_ads_exampleTests target in the example xcodeproj so it points to the right xcframework. This lets us run the tests from xcode. For some reason this broke after updating Google-Mobile-Ads-SDK past 9.10.

Related Issues

*Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the [Flutter Style Guide].
  • I signed the [CLA].
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@jjliu15 jjliu15 force-pushed the use_xcodebuild_for_ios_unit_tests branch from 30c3dd8 to a48e5d5 Compare March 3, 2023 00:16
@jjliu15 jjliu15 closed this Mar 6, 2023
@jjliu15 jjliu15 reopened this Mar 6, 2023
@jjliu15 jjliu15 merged commit 6f791ce into googleads:main Mar 6, 2023
@jjliu15 jjliu15 deleted the use_xcodebuild_for_ios_unit_tests branch March 6, 2023 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants