Skip to content

Commit 5180251

Browse files
authored
chore(test): ensure writeLogEntries is actually called on log write. (#721)
1 parent 4c53ff8 commit 5180251

2 files changed

Lines changed: 342 additions & 519 deletions

File tree

handwritten/logging/src/log.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -867,6 +867,7 @@ class Log implements LogSeverityFunctions {
867867
}
868868
}
869869

870+
// TODO proper signature of `private decorateEntries` (sans underscore suffix)
870871
/**
871872
* All entries are passed through here in order to get them serialized.
872873
*
@@ -887,6 +888,7 @@ class Log implements LogSeverityFunctions {
887888
});
888889
}
889890

891+
// TODO consider refactoring `truncateEntries` so that it does not mutate
890892
/**
891893
* Truncate log entries at maxEntrySize, so that error is not thrown, see:
892894
* https://cloud.google.com/logging/quotas

0 commit comments

Comments
 (0)