Skip to content

Commit 666b892

Browse files
committed
Updating lint rules to account for new generated files.
1 parent 7e2e7ad commit 666b892

File tree

3 files changed

+6
-8
lines changed

3 files changed

+6
-8
lines changed

pylintrc_default

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,8 @@
2727
# DEFAULT: ignore=CVS
2828
# NOTE: This path must be relative due to the use of
2929
# os.walk in astroid.modutils.get_module_files.
30-
# RATIONALE:
31-
# _datastore_v1_pb2.py: protobuf-generated code.
32-
ignore =
33-
_datastore_v1_pb2.py
30+
# RATIONALE: No files to ignore.
31+
ignore=
3432

3533
# Pickle collected data for later comparisons.
3634
# DEFAULT: persistent=yes

run_pylint.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,11 +29,11 @@
2929

3030

3131
IGNORED_DIRECTORIES = [
32-
'gcloud/bigtable/_generated',
32+
os.path.join('gcloud', 'bigtable', '_generated'),
33+
os.path.join('gcloud', 'datastore', '_generated'),
3334
]
3435
IGNORED_FILES = [
35-
'gcloud/datastore/_datastore_v1_pb2.py',
36-
'docs/conf.py',
36+
os.path.join('docs', 'conf.py'),
3737
'setup.py',
3838
]
3939
PRODUCTION_RC = 'pylintrc_default'

tox.ini

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ deps = {[testenv:docs]deps}
6363
passenv = {[testenv:docs]passenv}
6464

6565
[pep8]
66-
exclude = gcloud/datastore/_datastore_v1_pb2.py,gcloud/bigtable/_generated/*,docs/conf.py
66+
exclude = docs/conf.py,gcloud/bigtable/_generated/*,gcloud/datastore/_generated/*
6767
verbose = 1
6868

6969
[testenv:lint]

0 commit comments

Comments
 (0)