Skip to content

Commit 9ab3e25

Browse files
gcf-owl-bot[bot]gcf-owl-bot[bot]
authored
fix: Add async context manager return types (#72)
* fix: Add async context manager return types chore: Mock return_value should not populate oneof message fields chore: Support snippet generation for services that only support REST transport chore: Update gapic-generator-python to v1.11.0 PiperOrigin-RevId: 545430278 Source-Link: googleapis/googleapis@601b532 Source-Link: googleapis/googleapis-gen@b3f18d0 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjNmMThkMGY2NTYwYTg1NTAyMmZkMDU4ODY1ZTc2MjA0NzlkN2FmOSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
1 parent d368751 commit 9ab3e25

3 files changed

Lines changed: 28 additions & 16 deletions

File tree

‎packages/google-cloud-gke-backup/google/cloud/gke_backup_v1/services/backup_for_gke/async_client.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3939,7 +3939,7 @@ async def list_locations(
39393939
# Done; return the response.
39403940
return response
39413941

3942-
async def __aenter__(self):
3942+
async def __aenter__(self) -> "BackupForGKEAsyncClient":
39433943
return self
39443944

39453945
async def __aexit__(self, exc_type, exc, tb):

‎packages/google-cloud-gke-backup/google/cloud/gke_backup_v1/services/backup_for_gke/transports/rest.py‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3875,7 +3875,7 @@ def __call__(
38753875
request_kwargs = json_format.MessageToDict(request)
38763876
transcoded_request = path_template.transcode(http_options, **request_kwargs)
38773877

3878-
body = json.loads(json.dumps(transcoded_request["body"]))
3878+
body = json.dumps(transcoded_request["body"])
38793879
uri = transcoded_request["uri"]
38803880
method = transcoded_request["method"]
38813881

@@ -3972,7 +3972,7 @@ def __call__(
39723972
request_kwargs = json_format.MessageToDict(request)
39733973
transcoded_request = path_template.transcode(http_options, **request_kwargs)
39743974

3975-
body = json.loads(json.dumps(transcoded_request["body"]))
3975+
body = json.dumps(transcoded_request["body"])
39763976
uri = transcoded_request["uri"]
39773977
method = transcoded_request["method"]
39783978

@@ -4041,7 +4041,7 @@ def __call__(
40414041
request_kwargs = json_format.MessageToDict(request)
40424042
transcoded_request = path_template.transcode(http_options, **request_kwargs)
40434043

4044-
body = json.loads(json.dumps(transcoded_request["body"]))
4044+
body = json.dumps(transcoded_request["body"])
40454045
uri = transcoded_request["uri"]
40464046
method = transcoded_request["method"]
40474047

‎packages/google-cloud-gke-backup/tests/unit/gapic/gke_backup_v1/test_backup_for_gke.py‎

Lines changed: 24 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1413,9 +1413,11 @@ async def test_list_backup_plans_async_pages():
14131413
RuntimeError,
14141414
)
14151415
pages = []
1416-
async for page_ in (
1416+
# Workaround issue in python 3.9 related to code coverage by adding `# pragma: no branch`
1417+
# See https://github.com/googleapis/gapic-generator-python/pull/1174#issuecomment-1025132372
1418+
async for page_ in ( # pragma: no branch
14171419
await client.list_backup_plans(request={})
1418-
).pages: # pragma: no branch
1420+
).pages:
14191421
pages.append(page_)
14201422
for page_, token in zip(pages, ["abc", "def", "ghi", ""]):
14211423
assert page_.raw_page.next_page_token == token
@@ -2833,9 +2835,11 @@ async def test_list_backups_async_pages():
28332835
RuntimeError,
28342836
)
28352837
pages = []
2836-
async for page_ in (
2838+
# Workaround issue in python 3.9 related to code coverage by adding `# pragma: no branch`
2839+
# See https://github.com/googleapis/gapic-generator-python/pull/1174#issuecomment-1025132372
2840+
async for page_ in ( # pragma: no branch
28372841
await client.list_backups(request={})
2838-
).pages: # pragma: no branch
2842+
).pages:
28392843
pages.append(page_)
28402844
for page_, token in zip(pages, ["abc", "def", "ghi", ""]):
28412845
assert page_.raw_page.next_page_token == token
@@ -4026,9 +4030,11 @@ async def test_list_volume_backups_async_pages():
40264030
RuntimeError,
40274031
)
40284032
pages = []
4029-
async for page_ in (
4033+
# Workaround issue in python 3.9 related to code coverage by adding `# pragma: no branch`
4034+
# See https://github.com/googleapis/gapic-generator-python/pull/1174#issuecomment-1025132372
4035+
async for page_ in ( # pragma: no branch
40304036
await client.list_volume_backups(request={})
4031-
).pages: # pragma: no branch
4037+
).pages:
40324038
pages.append(page_)
40334039
for page_, token in zip(pages, ["abc", "def", "ghi", ""]):
40344040
assert page_.raw_page.next_page_token == token
@@ -5010,9 +5016,11 @@ async def test_list_restore_plans_async_pages():
50105016
RuntimeError,
50115017
)
50125018
pages = []
5013-
async for page_ in (
5019+
# Workaround issue in python 3.9 related to code coverage by adding `# pragma: no branch`
5020+
# See https://github.com/googleapis/gapic-generator-python/pull/1174#issuecomment-1025132372
5021+
async for page_ in ( # pragma: no branch
50145022
await client.list_restore_plans(request={})
5015-
).pages: # pragma: no branch
5023+
).pages:
50165024
pages.append(page_)
50175025
for page_, token in zip(pages, ["abc", "def", "ghi", ""]):
50185026
assert page_.raw_page.next_page_token == token
@@ -6430,9 +6438,11 @@ async def test_list_restores_async_pages():
64306438
RuntimeError,
64316439
)
64326440
pages = []
6433-
async for page_ in (
6441+
# Workaround issue in python 3.9 related to code coverage by adding `# pragma: no branch`
6442+
# See https://github.com/googleapis/gapic-generator-python/pull/1174#issuecomment-1025132372
6443+
async for page_ in ( # pragma: no branch
64346444
await client.list_restores(request={})
6435-
).pages: # pragma: no branch
6445+
).pages:
64366446
pages.append(page_)
64376447
for page_, token in zip(pages, ["abc", "def", "ghi", ""]):
64386448
assert page_.raw_page.next_page_token == token
@@ -7606,9 +7616,11 @@ async def test_list_volume_restores_async_pages():
76067616
RuntimeError,
76077617
)
76087618
pages = []
7609-
async for page_ in (
7619+
# Workaround issue in python 3.9 related to code coverage by adding `# pragma: no branch`
7620+
# See https://github.com/googleapis/gapic-generator-python/pull/1174#issuecomment-1025132372
7621+
async for page_ in ( # pragma: no branch
76107622
await client.list_volume_restores(request={})
7611-
).pages: # pragma: no branch
7623+
).pages:
76127624
pages.append(page_)
76137625
for page_, token in zip(pages, ["abc", "def", "ghi", ""]):
76147626
assert page_.raw_page.next_page_token == token

0 commit comments

Comments
 (0)