Skip to content

Commit ad0557d

Browse files
committed
Forward connection w/o interception to 'ACL.save'.
1 parent 6dc5c56 commit ad0557d

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

gcloud/storage/blob.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -521,8 +521,6 @@ def make_public(self, connection=None):
521521
:param connection: Optional. The connection to use when sending
522522
requests. If not provided, falls back to default.
523523
"""
524-
if connection is None:
525-
connection = self.connection
526524
self.acl.all().grant_read()
527525
self.acl.save(connection=connection)
528526

gcloud/storage/test_blob.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -729,7 +729,7 @@ def test_upload_from_string_w_text(self):
729729
self.assertEqual(headers['Content-Type'], 'text/plain')
730730
self.assertEqual(rq[0]['body'], ENCODED)
731731

732-
def test_make_public(self):
732+
def test_make_public_w_implicit_ocnnection(self):
733733
from gcloud.storage.acl import _ACLEntity
734734
from gcloud.storage._testing import _monkey_defaults
735735
BLOB_NAME = 'blob-name'

0 commit comments

Comments
 (0)