Skip to content

Commit db79577

Browse files
fix: remove client recv msg limit and add enums to types/__init__.py (#40)
PiperOrigin-RevId: 347055288 Source-Author: Google APIs <[email protected]> Source-Date: Fri Dec 11 12:44:37 2020 -0800 Source-Repo: googleapis/googleapis Source-Sha: dd372aa22ded7a8ba6f0e03a80e06358a3fa0907 Source-Link: googleapis/googleapis@dd372aa
1 parent 2fe210c commit db79577

File tree

6 files changed

+30
-6
lines changed

6 files changed

+30
-6
lines changed

packages/google-cloud-access-approval/google/cloud/accessapproval_v1/services/access_approval/transports/__init__.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
_transport_registry["grpc"] = AccessApprovalGrpcTransport
2929
_transport_registry["grpc_asyncio"] = AccessApprovalGrpcAsyncIOTransport
3030

31-
3231
__all__ = (
3332
"AccessApprovalTransport",
3433
"AccessApprovalGrpcTransport",

packages/google-cloud-access-approval/google/cloud/accessapproval_v1/services/access_approval/transports/grpc.py

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -181,6 +181,10 @@ def __init__(
181181
ssl_credentials=ssl_credentials,
182182
scopes=scopes or self.AUTH_SCOPES,
183183
quota_project_id=quota_project_id,
184+
options=[
185+
("grpc.max_send_message_length", -1),
186+
("grpc.max_receive_message_length", -1),
187+
],
184188
)
185189
self._ssl_channel_credentials = ssl_credentials
186190
else:
@@ -199,6 +203,10 @@ def __init__(
199203
ssl_credentials=ssl_channel_credentials,
200204
scopes=scopes or self.AUTH_SCOPES,
201205
quota_project_id=quota_project_id,
206+
options=[
207+
("grpc.max_send_message_length", -1),
208+
("grpc.max_receive_message_length", -1),
209+
],
202210
)
203211

204212
self._stubs = {} # type: Dict[str, Callable]
@@ -225,7 +233,7 @@ def create_channel(
225233
) -> grpc.Channel:
226234
"""Create and return a gRPC channel object.
227235
Args:
228-
address (Optionsl[str]): The host for the channel to use.
236+
address (Optional[str]): The host for the channel to use.
229237
credentials (Optional[~.Credentials]): The
230238
authorization credentials to attach to requests. These
231239
credentials identify this application to the service. If

packages/google-cloud-access-approval/google/cloud/accessapproval_v1/services/access_approval/transports/grpc_asyncio.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -226,6 +226,10 @@ def __init__(
226226
ssl_credentials=ssl_credentials,
227227
scopes=scopes or self.AUTH_SCOPES,
228228
quota_project_id=quota_project_id,
229+
options=[
230+
("grpc.max_send_message_length", -1),
231+
("grpc.max_receive_message_length", -1),
232+
],
229233
)
230234
self._ssl_channel_credentials = ssl_credentials
231235
else:
@@ -244,6 +248,10 @@ def __init__(
244248
ssl_credentials=ssl_channel_credentials,
245249
scopes=scopes or self.AUTH_SCOPES,
246250
quota_project_id=quota_project_id,
251+
options=[
252+
("grpc.max_send_message_length", -1),
253+
("grpc.max_receive_message_length", -1),
254+
],
247255
)
248256

249257
# Run the base constructor.

packages/google-cloud-access-approval/google/cloud/accessapproval_v1/types/__init__.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,9 @@
3232
GetAccessApprovalSettingsMessage,
3333
UpdateAccessApprovalSettingsMessage,
3434
DeleteAccessApprovalSettingsMessage,
35+
EnrollmentLevel,
3536
)
3637

37-
3838
__all__ = (
3939
"AccessLocations",
4040
"AccessReason",
@@ -52,4 +52,5 @@
5252
"GetAccessApprovalSettingsMessage",
5353
"UpdateAccessApprovalSettingsMessage",
5454
"DeleteAccessApprovalSettingsMessage",
55+
"EnrollmentLevel",
5556
)

packages/google-cloud-access-approval/synth.metadata

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,15 +4,15 @@
44
"git": {
55
"name": ".",
66
"remote": "https://github.com/googleapis/python-access-approval.git",
7-
"sha": "bdf9e41f796e8da5db53d54c8bb2da4d7ee24acc"
7+
"sha": "7c682116987ed328a58d788b10f93e0a0d09bf73"
88
}
99
},
1010
{
1111
"git": {
1212
"name": "googleapis",
1313
"remote": "https://github.com/googleapis/googleapis.git",
14-
"sha": "3ac5ef0436d8dfeb2ca0091dc7fa8012da1c85af",
15-
"internalRef": "342835449"
14+
"sha": "dd372aa22ded7a8ba6f0e03a80e06358a3fa0907",
15+
"internalRef": "347055288"
1616
}
1717
},
1818
{

packages/google-cloud-access-approval/tests/unit/gapic/accessapproval_v1/test_access_approval.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2238,6 +2238,10 @@ def test_access_approval_transport_channel_mtls_with_client_cert_source(
22382238
scopes=("https://www.googleapis.com/auth/cloud-platform",),
22392239
ssl_credentials=mock_ssl_cred,
22402240
quota_project_id=None,
2241+
options=[
2242+
("grpc.max_send_message_length", -1),
2243+
("grpc.max_receive_message_length", -1),
2244+
],
22412245
)
22422246
assert transport.grpc_channel == mock_grpc_channel
22432247
assert transport._ssl_channel_credentials == mock_ssl_cred
@@ -2279,6 +2283,10 @@ def test_access_approval_transport_channel_mtls_with_adc(transport_class):
22792283
scopes=("https://www.googleapis.com/auth/cloud-platform",),
22802284
ssl_credentials=mock_ssl_cred,
22812285
quota_project_id=None,
2286+
options=[
2287+
("grpc.max_send_message_length", -1),
2288+
("grpc.max_receive_message_length", -1),
2289+
],
22822290
)
22832291
assert transport.grpc_channel == mock_grpc_channel
22842292

0 commit comments

Comments
 (0)