Skip to content

Conversation

@summer-ji-eng
Copy link
Contributor

@summer-ji-eng summer-ji-eng commented Feb 2, 2022

  • Regenerate this pull request now.

PiperOrigin-RevId: 419710013

Source-Link: googleapis/googleapis@b7c9d05

Source-Link: https://github.com/googleapis/googleapis-gen/commit/ae498279c4e71cd4aa6e0655e92a693df97472c4
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYWU0OTgyNzljNGU3MWNkNGFhNmUwNjU1ZTkyYTY5M2RmOTc0NzJjNCJ9

Manually update admin code: bazel build //google/firestore/admin/v1:firestore-admin-v1-nodejs

owlbot

docker run --rm --user $(id -u):$(id -g)   -v $(pwd):/repo   -v $GOOGLEAPIS/bazel-bin:/bazel-bin   gcr.io/cloud-devrel-public-resources/owlbot-cli:latest copy-bazel-bin   --source-dir /bazel-bin --dest /repo

and post-processor

docker run  --user $(id -u):$(id -g) --rm -v $(pwd):/repo -w /repo $IMAGE

fix #1653

@summer-ji-eng summer-ji-eng requested review from a team as code owners February 2, 2022 06:20
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/nodejs-firestore API. label Feb 2, 2022
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

@summer-ji-eng summer-ji-eng requested a review from bcoe February 2, 2022 06:21
@gcf-owl-bot
Copy link
Contributor

gcf-owl-bot bot commented Feb 2, 2022

Owl bot is regenerating pull request 1676...
Build name: NmFmOGRlMjctODQyNS00MjU3LThlZTAtY2JjY2MwMGNkOGZl

@snippet-bot
Copy link

snippet-bot bot commented Feb 2, 2022

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@bcoe bcoe changed the title build: manual update admin with latest protos feat: update client libraries to support Database operations Feb 2, 2022
@bcoe bcoe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 4, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 4, 2022
Copy link

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 awaiting @schmidt-sebastian's review.

@bcoe bcoe added the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 4, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 4, 2022
Copy link
Contributor Author

@summer-ji-eng summer-ji-eng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change in v1/firestore_client.ts, dev/src/v1beta1/firestore_client.ts, dev/src/v1beta1/firestore_client.ts, dev/test/gapic_firestore_v1.ts is from generator fix.
The fix PR in gapic-generator-typescript.

@summer-ji-eng
Copy link
Contributor Author

Linter issue would be fix in googleapis/google-cloud-node-core#578
Fix pr

@summer-ji-eng
Copy link
Contributor Author

@schmidt-sebastian PR is ready for another review. Thank you.

@schmidt-sebastian schmidt-sebastian merged commit 533aade into main Feb 7, 2022
@schmidt-sebastian schmidt-sebastian deleted the admin_update branch February 7, 2022 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: firestore Issues related to the googleapis/nodejs-firestore API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants