Skip to content

Conversation

@tom-andersen
Copy link
Contributor

@tom-andersen tom-andersen commented Oct 27, 2023

Remove temporary workaround to header encoding issue b/291780066.

The workaround appears to cause trouble for some customers.
#1929

@tom-andersen tom-andersen requested review from a team as code owners October 27, 2023 15:46
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: firestore Issues related to the googleapis/nodejs-firestore API. labels Oct 27, 2023
@tom-andersen tom-andersen changed the title fix: Remove header encoding workaround fix: Remove temporary header encoding workaround Oct 27, 2023
Copy link
Contributor

@MarkDuckworth MarkDuckworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The lint error should be fixed though.

@tom-andersen tom-andersen merged commit 8a4ae5b into main Nov 9, 2023
@tom-andersen tom-andersen deleted the tomandersen/removeWorkaround branch November 9, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: firestore Issues related to the googleapis/nodejs-firestore API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants