Skip to content

Conversation

@MarkDuckworth
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@MarkDuckworth MarkDuckworth added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Mar 19, 2024
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Mar 19, 2024
@MarkDuckworth MarkDuckworth added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 20, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 20, 2024
Copy link
Contributor

@wu-hui wu-hui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed by commits, maybe my comments no longer apply if you already fixed them in a different commits.

The comments are minor anyways, so LGTM!

@MarkDuckworth MarkDuckworth changed the title FN prep feat: Vector Search Mar 27, 2024
@MarkDuckworth MarkDuckworth added do not merge Indicates a pull request not ready for merge, due to either quality or timing. owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 27, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 27, 2024
Copy link
Contributor

@sofisl sofisl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the breaking changes:

query.toProto() --> query._toProto()

for this release

@MarkDuckworth MarkDuckworth removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 2, 2024
@MarkDuckworth MarkDuckworth merged commit e906b42 into main Apr 2, 2024
@MarkDuckworth MarkDuckworth deleted the markduckworth/findnearest branch April 2, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: firestore Issues related to the googleapis/nodejs-firestore API. size: xl Pull request size is extra large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants