Skip to content

fix: ReadOnly transactions do not need to commit nor rollback. #2007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tom-andersen merged 1 commit into from
Mar 6, 2024
Merged

fix: ReadOnly transactions do not need to commit nor rollback. #2007

tom-andersen merged 1 commit into from
Mar 6, 2024

Conversation

@tom-andersen
Copy link
Contributor

@tom-andersen tom-andersen commented Mar 4, 2024 •
edited
Loading

No description provided.

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: firestore Issues related to the googleapis/nodejs-firestore API. labels Mar 4, 2024
@tom-andersen tom-andersen changed the title fix: ReadOnly transaction do not need to commit not rollback. fix: ReadOnly transaction do not need to commit nor rollback. Mar 4, 2024
@tom-andersen tom-andersen marked this pull request as ready for review March 5, 2024 00:15
@tom-andersen tom-andersen requested review from a team as code owners March 5, 2024 00:15
@tom-andersen tom-andersen requested a review from ehsannas March 5, 2024 00:17
@tom-andersen tom-andersen changed the title fix: ReadOnly transaction do not need to commit nor rollback. fix: ReadOnly transactions do not need to commit nor rollback. Mar 5, 2024
@tom-andersen tom-andersen added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 5, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 5, 2024
@tom-andersen tom-andersen merged commit 6a220a6 into main Mar 6, 2024
@tom-andersen tom-andersen deleted the tomandersen/readOnlyTransactionsOptimization branch March 6, 2024 19:12
@release-please release-please bot mentioned this pull request Mar 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ehsannas ehsannas ehsannas approved these changes

Assignees

@ehsannas ehsannas

Labels

api: firestore Issues related to the googleapis/nodejs-firestore API. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tom-andersen @ehsannas