Skip to content

fix: Firestore Client caching stub in bad state issue #2365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wu-hui merged 11 commits into from
Jun 19, 2025
Merged

fix: Firestore Client caching stub in bad state issue #2365

wu-hui merged 11 commits into from
Jun 19, 2025

Conversation

@wu-hui
Copy link
Contributor

@wu-hui wu-hui commented Jun 16, 2025 •
edited by MarkDuckworth
Loading

fixes b/421230880

@wu-hui wu-hui requested review from a team as code owners June 16, 2025 23:57
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: firestore Issues related to the googleapis/nodejs-firestore API. labels Jun 16, 2025
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels Jun 17, 2025
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: m Pull request size is medium. labels Jun 17, 2025
@wu-hui wu-hui requested a review from MarkDuckworth June 17, 2025 03:18
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Jun 17, 2025
MarkDuckworth
MarkDuckworth previously approved these changes Jun 17, 2025
View reviewed changes
@wu-hui wu-hui closed this Jun 18, 2025
@wu-hui wu-hui reopened this Jun 18, 2025
@wu-hui wu-hui added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jun 18, 2025
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jun 18, 2025
@wu-hui wu-hui added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 18, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 18, 2025
tom-andersen
tom-andersen reviewed Jun 18, 2025
View reviewed changes
tom-andersen
tom-andersen previously approved these changes Jun 18, 2025
View reviewed changes
Copy link
Contributor

@tom-andersen tom-andersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarkDuckworth MarkDuckworth dismissed stale reviews from tom-andersen and themself via bb97d2a June 18, 2025 15:56
@wu-hui wu-hui added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 18, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 18, 2025
@wu-hui wu-hui added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 18, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 18, 2025
@wu-hui wu-hui merged commit 04ad0a4 into main Jun 19, 2025
19 checks passed
@wu-hui wu-hui deleted the wuandy/StubFix branch June 19, 2025 01:45
@release-please release-please bot mentioned this pull request Jun 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MarkDuckworth MarkDuckworth MarkDuckworth approved these changes

@ehsannas ehsannas ehsannas approved these changes

@tom-andersen tom-andersen tom-andersen left review comments

Assignees

@MarkDuckworth MarkDuckworth

Labels

api: firestore Issues related to the googleapis/nodejs-firestore API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wu-hui @MarkDuckworth @ehsannas @tom-andersen @yoshi-kokoro