Skip to content

Commit b711815

Browse files
fix: join on, how args are now positional (#2140)
1 parent ece0762 commit b711815

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

bigframes/dataframe.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3721,7 +3721,6 @@ def _validate_left_right_on(
37213721
def join(
37223722
self,
37233723
other: Union[DataFrame, bigframes.series.Series],
3724-
*,
37253724
on: Optional[str] = None,
37263725
how: str = "left",
37273726
lsuffix: str = "",

third_party/bigframes_vendored/pandas/core/frame.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4601,9 +4601,8 @@ def map(self, func, na_action: Optional[str] = None) -> DataFrame:
46014601
def join(
46024602
self,
46034603
other,
4604-
*,
46054604
on: Optional[str] = None,
4606-
how: str,
4605+
how: str = "left",
46074606
lsuffix: str = "",
46084607
rsuffix: str = "",
46094608
) -> DataFrame:

0 commit comments

Comments
 (0)