Skip to content

docs: update Session doctrings to include exceptions #1130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 12, 2024
Merged

docs: update Session doctrings to include exceptions #1130

merged 5 commits into from
Nov 12, 2024

Conversation

@arwas11
Copy link
Contributor

@arwas11 arwas11 commented Nov 5, 2024 •
edited
Loading

6Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary):
    • read_gbq_query: screen/3Lgd5sqbXUoEXxp
    • read_gbq_table: screen/9FTpfsmfpT2Ni73
    • read_gbq: screen/BjyHZmopRVG2Gq3
    • read_json: screen/5RqZreELZtEYUS6

Fixes #296390934 🦕

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Nov 5, 2024
@arwas11 arwas11 marked this pull request as ready for review November 8, 2024 19:29
@arwas11 arwas11 requested review from a team as code owners November 8, 2024 19:29
@arwas11 arwas11 requested review from GarrettWu and tswast November 8, 2024 19:29
@arwas11 arwas11 requested a review from Genesis929 November 8, 2024 19:54
@arwas11 arwas11 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 8, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 8, 2024
@arwas11 arwas11 merged commit a870421 into main Nov 12, 2024
23 checks passed
@arwas11 arwas11 deleted the b296390934-docstrings-exceptions-core-objs branch November 12, 2024 15:28
@release-please release-please bot mentioned this pull request Nov 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GarrettWu GarrettWu GarrettWu approved these changes

@Genesis929 Genesis929 Genesis929 approved these changes

@tswast tswast Awaiting requested review from tswast tswast is a code owner automatically assigned from googleapis/api-bigquery-dataframe

Assignees

No one assigned

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@arwas11 @GarrettWu @Genesis929 @yoshi-kokoro @mattyopl