Skip to content

feat: support passing list of values to bigframes.core.sql.simple_literal #1641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 22, 2025

Conversation

arwas11
Copy link
Contributor

@arwas11 arwas11 commented Apr 22, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #409559725 🦕

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Apr 22, 2025
@arwas11 arwas11 changed the title B409559725 json string feat: support passing list of values to bigframes.core.sql.simple_literal Apr 22, 2025
Copy link
Collaborator

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@arwas11 arwas11 marked this pull request as ready for review April 22, 2025 17:28
@arwas11 arwas11 requested review from a team as code owners April 22, 2025 17:28
@arwas11 arwas11 requested a review from jialuoo April 22, 2025 17:28
@arwas11
Copy link
Contributor Author

arwas11 commented Apr 22, 2025

Unrelated e2e failure:

=========================== short test summary info ============================
FAILED tests/system/large/functions/test_managed_function.py::test_managed_function_series_combine

@arwas11 arwas11 merged commit 102d363 into main Apr 22, 2025
24 checks passed
@arwas11 arwas11 deleted the b409559725-json-string branch April 22, 2025 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants