Skip to content

docs: include the clean-up step in the udf code snippet #1698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 7, 2025

Conversation

shobsi
Copy link
Contributor

@shobsi shobsi commented May 6, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@shobsi shobsi requested review from a team as code owners May 6, 2025 20:56
@shobsi shobsi requested review from balajismaniam and tswast May 6, 2025 20:56
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label May 6, 2025
@product-auto-label product-auto-label bot added api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. samples Issues that are directly related to samples. labels May 6, 2025
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels May 6, 2025
@tswast
Copy link
Collaborator

tswast commented May 7, 2025

doctest failure seems unrelated to this change:

___________ [doctest] indexes.accessor.DatetimeProperties.dayofyear ____________
[gw4] linux -- Python 3.12.7 /tmpfs/src/github/python-bigquery-dataframes/.nox/doctest/bin/python
072 
073         **Examples:**
074 
075             >>> import pandas as pd
076             >>> import bigframes.pandas as bpd
077             >>> bpd.options.display.progress_bar = None
078             >>> s = bpd.Series(
079             ...     pd.date_range('2016-12-28', '2017-01-03', freq='D').to_series()
080             ... )
081             >>> s.dt.dayofyear
Differences (unified diff with -expected +actual):
    @@ -7,3 +7,2 @@
     2017-01-03 00:00:00      3
     dtype: Int64
    -dtype: Int64

@tswast tswast merged commit 48992e2 into main May 7, 2025
24 checks passed
@tswast tswast deleted the shobsi-udf-snippet-cleanup branch May 7, 2025 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. samples Issues that are directly related to samples. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants