-
Notifications
You must be signed in to change notification settings - Fork 62
feat: enhanced multimodal error handling with verbose mode for blob image functions #2024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
90e7d33 to
cde2a61
Compare
32fa87c to
623f9ba
Compare
1a873bc to
75d69a7
Compare
This reverts commit 9a5bcd2.
75d69a7 to
53528c7
Compare
| check_index_type=False, | ||
| engine="pillow", connection=bq_connection, verbose=verbose | ||
| ) | ||
| if verbose: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we usually don't put logics in unit tests: go/unit-testing-practices?polyglot=python#logic
In this case, we should use two test methods to avoid the "if-else" branch: test_blob_exif and text_blob_exif_verbose
The same suggestion applies to other test methods too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have modified all testcases as suggested. I also checked the failed testcase. They are unrelated to this change.
Here are the changes:
Fixes #<403365429> 🦕