Skip to content

feat: support to cast struct to json #2067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 10, 2025
Merged

feat: support to cast struct to json #2067

merged 1 commit into from
Sep 10, 2025

Conversation

@chelsea-lin
Copy link
Contributor

@chelsea-lin chelsea-lin commented Sep 10, 2025

Fixes internal issue 444196993 🦕

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Sep 10, 2025
@chelsea-lin chelsea-lin marked this pull request as ready for review September 10, 2025 21:50
@chelsea-lin chelsea-lin requested review from a team as code owners September 10, 2025 21:50
@chelsea-lin chelsea-lin requested a review from jialuoo September 10, 2025 21:50
@chelsea-lin chelsea-lin added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 10, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 10, 2025
@chelsea-lin chelsea-lin merged commit b0ff718 into main Sep 10, 2025
21 of 25 checks passed
@chelsea-lin chelsea-lin deleted the main_chelsealin_json branch September 10, 2025 21:59
@release-please release-please bot mentioned this pull request Sep 10, 2025
Merged
TrevorBergeron
TrevorBergeron requested changes Sep 10, 2025
View reviewed changes
Copy link
Contributor

@TrevorBergeron TrevorBergeron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please extend the astype engine test if we are extending cast operator.
I'd almost rather use a separate operator instead of the cast operator, as the casting operator is incredibly laden with logic

@chelsea-lin
Copy link
Contributor Author

chelsea-lin commented Sep 10, 2025

#2070 to follow up the astype engine test

chelsea-lin added a commit that referenced this pull request Sep 11, 2025
@chelsea-lin
Revert "feat: support to cast struct to json (#2067)"
0fba04d 
This reverts commit b0ff718.
@chelsea-lin chelsea-lin mentioned this pull request Sep 11, 2025
Merged
chelsea-lin added a commit that referenced this pull request Sep 11, 2025
@chelsea-lin
Revert "feat: support to cast struct to json (#2067)" (#2072)
fdf623d 
This reverts commit b0ff718.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrevorBergeron TrevorBergeron TrevorBergeron requested changes

@jialuoo jialuoo jialuoo approved these changes

Assignees

@TrevorBergeron TrevorBergeron

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chelsea-lin @TrevorBergeron @jialuoo