Skip to content

fix: Correct connection normalization in blob system tests #2222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 3, 2025
Merged

fix: Correct connection normalization in blob system tests #2222

merged 3 commits into from
Nov 3, 2025

Conversation

@shuoweil
Copy link
Contributor

@shuoweil shuoweil commented Nov 3, 2025 •
edited
Loading

This PR addresses a bug in the blob storage system tests where the normalize_connection_id fixture was incorrectly implemented, causing several tests to fail.

The key changes include:

  • Correcting the normalize_connection_id fixture to return a function that normalizes the connection ID.
  • Updating type hints in test_io.py and test_properties.py to use typing.Callable.
  • Applying the normalization function consistently across all relevant blob tests.
  • Skipping flaky tests related to blob properties and multimodal LLMs.

Fixes #<457416070> 🦕

@shuoweil shuoweil self-assigned this Nov 3, 2025
@shuoweil shuoweil requested review from a team as code owners November 3, 2025 21:25
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Nov 3, 2025
@chelsea-lin chelsea-lin changed the title Fix: Correct connection normalization in blob system tests fix: Correct connection normalization in blob system tests Nov 3, 2025
chelsea-lin
chelsea-lin requested changes Nov 3, 2025
View reviewed changes
Copy link
Contributor

@chelsea-lin chelsea-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit should be named starting with the "fix: " prefix.

@shuoweil shuoweil force-pushed the shuowei-connection-name-testcase branch from 6d5bf49 to 6cf4111 Compare November 3, 2025 21:33
@shuoweil shuoweil force-pushed the shuowei-connection-name-testcase branch from 6cf4111 to 680bf5d Compare November 3, 2025 21:35
@shuoweil shuoweil requested a review from chelsea-lin November 3, 2025 21:35
@shuoweil shuoweil enabled auto-merge (squash) November 3, 2025 23:27
@shuoweil shuoweil disabled auto-merge November 3, 2025 23:28
@shuoweil shuoweil merged commit a0e1e50 into main Nov 3, 2025
20 of 25 checks passed
@shuoweil shuoweil deleted the shuowei-connection-name-testcase branch November 3, 2025 23:56
@release-please release-please bot mentioned this pull request Nov 3, 2025
Merged
GarrettWu added a commit that referenced this pull request Nov 6, 2025
@GarrettWu
Revert "fix: Correct connection normalization in blob system tests (#…
e5685f8 
…2222)"

This reverts commit a0e1e50.
GarrettWu added a commit that referenced this pull request Nov 6, 2025
@GarrettWu
test: re-enable Multimodal tests (#2235)
4318d66 
* Revert "fix: Correct connection normalization in blob system tests (#2222)"

This reverts commit a0e1e50.

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chelsea-lin chelsea-lin chelsea-lin approved these changes

@tswast tswast Awaiting requested review from tswast

@GarrettWu GarrettWu Awaiting requested review from GarrettWu

@sycai sycai Awaiting requested review from sycai

@jialuoo jialuoo Awaiting requested review from jialuoo

Assignees

@shuoweil shuoweil

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shuoweil @chelsea-lin