Skip to content

Conversation

@tswast
Copy link
Collaborator

@tswast tswast commented Nov 4, 2025

Towards internal issue b/457755215 🦕

@tswast tswast requested review from a team as code owners November 4, 2025 18:12
@snippet-bot
Copy link

snippet-bot bot commented Nov 4, 2025

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Nov 4, 2025
@tswast
Copy link
Collaborator Author

tswast commented Nov 4, 2025

Python 3.9 failures look real. Need to bump the minimum SQLGlot version to support JSON literals, is my guess.

Edit: Done! I had to bump it even a bit further to avoid a bug with ltrim/rtrim.

@tswast
Copy link
Collaborator Author

tswast commented Nov 4, 2025

Internal cl/828117205 to hopefully fix the permissions error on the code sample.

@tswast tswast added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 5, 2025
@bigframes-bot bigframes-bot removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 5, 2025
def st_regionstats(
geography: Union[bigframes.series.Series, bigframes.geopandas.GeoSeries],
raster_id: str,
band: Optional[str] = None,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be consistent, we may want to make the optional args as kwargs.

def st_length(
    series: Union[bigframes.series.Series, bigframes.geopandas.GeoSeries],
    *,
    use_spheroid: bool = False,
)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I'm okay either way with this one. In my testing, BigQuery SQL actually accepts the optional parameters to ST_REGIONSTATS as either keyword arguments or positional, so the Python default seems sensible here.

@tswast tswast merged commit 10ec52f into main Nov 5, 2025
24 of 25 checks passed
@tswast tswast deleted the tswast-st-regionstats branch November 5, 2025 21:57
sycai pushed a commit that referenced this pull request Nov 10, 2025
🤖 I have created a release *beep* *boop*
---


##
[2.29.0](v2.28.0...v2.29.0)
(2025-11-10)


### Features

* Add bigframes.bigquery.st_regionstats to join raster data from Earth
Engine
([#2228](#2228))
([10ec52f](10ec52f))
* Add DataFrame.resample and Series.resample
([#2213](#2213))
([c9ca02c](c9ca02c))
* SQL Cell no longer escapes formatted string values
([#2245](#2245))
([d2d38f9](d2d38f9))
* Support left_index and right_index for merge
([#2220](#2220))
([da9ba26](da9ba26))


### Bug Fixes

* Correctly iterate over null struct values in ManagedArrowTable
([#2209](#2209))
([12e04d5](12e04d5))
* Simplify UnsupportedTypeError message
([#2212](#2212))
([6c9a18d](6c9a18d))
* Support results with STRUCT and ARRAY columns containing JSON
subfields in `to_pandas_batches()`
([#2216](#2216))
([3d8b17f](3d8b17f))


### Documentation

* Switch API reference docs to pydata theme
([#2237](#2237))
([9b86dcf](9b86dcf))
* Update notebook for JSON subfields support in to_pandas_batches()
([#2138](#2138))
([5663d2a](5663d2a))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants