Skip to content

Conversation

@rey-esp
Copy link
Contributor

@rey-esp rey-esp commented Nov 14, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

For inclusion in the Create a boosted tree classification model in BigQuery ML tutorial
🦕

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Nov 14, 2024
@product-auto-label product-auto-label bot added api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. samples Issues that are directly related to samples. labels Nov 14, 2024
@rey-esp rey-esp requested a review from tswast November 19, 2024 22:56
@rey-esp rey-esp marked this pull request as ready for review November 19, 2024 22:56
@rey-esp rey-esp requested review from a team as code owners November 19, 2024 22:56
@snippet-bot
Copy link

snippet-bot bot commented Nov 19, 2024

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@rey-esp rey-esp added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 20, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 20, 2024
Copy link
Collaborator

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Let's just fix up the read_gbq and to_gbq comments

Copy link
Collaborator

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@tswast tswast merged commit 9d8970a into main Nov 20, 2024
22 of 23 checks passed
@tswast tswast deleted the b338872698-bigframes-v2 branch November 20, 2024 15:50
@rey-esp rey-esp restored the b338872698-bigframes-v2 branch January 8, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. samples Issues that are directly related to samples. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants