From ce60c61751fc7371e65f80da2b0b039540e9359a Mon Sep 17 00:00:00 2001 From: Trevor Bergeron Date: Thu, 13 Mar 2025 22:09:43 +0000 Subject: [PATCH 1/2] chore: Finish factoring unit tests from presubmit --- noxfile.py | 16 +++------------- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/noxfile.py b/noxfile.py index 7dce51ab88..aa5ba51614 100644 --- a/noxfile.py +++ b/noxfile.py @@ -119,10 +119,10 @@ # Sessions are executed in the order so putting the smaller sessions # ahead to fail fast at presubmit running. nox.options.sessions = [ - "unit", "system-3.9", "system-3.12", "cover", + # TODO(b/401609005): remove "cleanup", ] @@ -458,21 +458,11 @@ def cover(session): "coverage", "report", "--include=bigframes/*", + # Only unit tested + "--omit=bigframes/core/compile/polars/*", "--show-missing", "--fail-under=85", ) - - # Make sure there is no dead code in our test directories. - session.run( - "coverage", - "report", - "--show-missing", - "--include=tests/unit/*", - "--include=tests/system/small/*", - # TODO(b/353775058) resume coverage to 100 when the issue is fixed. - "--fail-under=99", - ) - session.run("coverage", "erase") From 69027d9982ba2c4272326aea110f9ebefa84a00b Mon Sep 17 00:00:00 2001 From: Trevor Bergeron Date: Fri, 14 Mar 2025 19:32:58 +0000 Subject: [PATCH 2/2] adjust cover requirement to 83 --- noxfile.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/noxfile.py b/noxfile.py index aa5ba51614..fe425936d7 100644 --- a/noxfile.py +++ b/noxfile.py @@ -461,7 +461,7 @@ def cover(session): # Only unit tested "--omit=bigframes/core/compile/polars/*", "--show-missing", - "--fail-under=85", + "--fail-under=83", ) session.run("coverage", "erase")