Skip to content

feat: support pandas.Index as key for DataFrame.__setitem__() #2062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 10, 2025
Merged

feat: support pandas.Index as key for DataFrame.__setitem__() #2062

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a385219
feat: support pandas.Index as key for DataFrame.__setitem__()
sycai Sep 9, 2025
6f51947
fix format
sycai Sep 9, 2025
20492f4
Merge branch 'main' into sycai_multi_col_assign
sycai Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions bigframes/dataframe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -890,9 +890,11 @@ def __delitem__(self, key: str):
self._set_block(df._get_block())

def __setitem__(
self, key: str | list[str], value: SingleItemValue | MultiItemValue
self,
key: str | list[str] | pandas.Index,
value: SingleItemValue | MultiItemValue,
):
if isinstance(key, list):
if isinstance(key, (list, pandas.Index)):
df = self._assign_multi_items(key, value)
else:
df = self._assign_single_item(key, value)
Expand Down Expand Up @@ -2246,7 +2248,7 @@ def _assign_single_item(

def _assign_multi_items(
self,
k: list[str],
k: list[str] | pandas.Index,
v: SingleItemValue | MultiItemValue,
) -> DataFrame:
value_sources: Sequence[Any] = []
Expand Down
5 changes: 5 additions & 0 deletions tests/system/small/test_dataframe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1197,6 +1197,11 @@ def test_assign_new_column_w_setitem_list_error(scalars_dfs):
pytest.param(
["new_col", "new_col_too"], [1, 2], id="sequence_to_full_new_column"
),
pytest.param(
pd.Index(("new_col", "new_col_too")),
[1, 2],
id="sequence_to_full_new_column_as_index",
),
],
)
def test_setitem_multicolumn_with_literals(scalars_dfs, key, value):
Expand Down