Skip to content

fix: Use the remote and managed functions in the results #2079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 12, 2025
Merged

fix: Use the remote and managed functions in the results #2079

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad28793
fix: Use the remote and managed functions for bigframes results
jialuoo Sep 9, 2025
6e57110
Merge branch 'main' into fix-function-test
jialuoo Sep 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/system/large/functions/test_managed_function.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1166,7 +1166,7 @@ def is_sum_positive_series(s):
pd_int64_df_filtered = pd_int64_df.dropna()

# Test callable condition in dataframe.where method.
bf_result = bf_int64_df_filtered.where(is_sum_positive_series).to_pandas()
bf_result = bf_int64_df_filtered.where(is_sum_positive_series_mf).to_pandas()
pd_result = pd_int64_df_filtered.where(is_sum_positive_series)

# Ignore any dtype difference.
Expand Down
2 changes: 1 addition & 1 deletion tests/system/large/functions/test_remote_function.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3072,7 +3072,7 @@ def func_for_other(x):

# Test callable condition in dataframe.where method.
bf_result = bf_int64_df_filtered.where(
is_sum_positive_series, func_for_other
is_sum_positive_series_mf, func_for_other
).to_pandas()
pd_result = pd_int64_df_filtered.where(is_sum_positive_series, func_for_other)

Expand Down