Skip to content

fix: do not scroll page selector in anywidget repr_mode #2082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 15, 2025
Merged

fix: do not scroll page selector in anywidget repr_mode #2082

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d37d613
fix: do not scroll page selector in anywidget `repr_mode`
tswast Sep 15, 2025
e084e88
Merge branch 'main' into tswast-anywidget-scrollable-pagination
tswast Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ repos:
exclude: "^third_party"
args: ["--check-untyped-defs", "--explicit-package-bases", "--ignore-missing-imports"]
- repo: https://github.com/biomejs/pre-commit
rev: v2.0.2
rev: v2.2.4
hooks:
- id: biome-check
files: '\.(js|css)$'
3 changes: 2 additions & 1 deletion bigframes/display/table_widget.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@
*/

.bigframes-widget {
display: inline-block;
display: flex;
flex-direction: column;
}

.bigframes-widget .table-container {
Expand Down
48 changes: 18 additions & 30 deletions notebooks/dataframes/anywidget_mode.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
},
{
"cell_type": "code",
"execution_count": 2,
"execution_count": 1,
"id": "ca22f059",
"metadata": {},
"outputs": [],
Expand All @@ -50,7 +50,7 @@
},
{
"cell_type": "code",
"execution_count": 3,
"execution_count": 2,
"id": "1bc5aaf3",
"metadata": {},
"outputs": [],
Expand All @@ -69,22 +69,10 @@
},
{
"cell_type": "code",
"execution_count": 4,
"execution_count": 3,
"id": "f289d250",
"metadata": {},
"outputs": [
{
"data": {
"text/html": [
"Query job a643d120-4af9-44fc-ba3c-ed461cf1092b is DONE. 0 Bytes processed. <a target=\"_blank\" href=\"https://console.cloud.google.com/bigquery?project=bigframes-dev&j=bq:US:a643d120-4af9-44fc-ba3c-ed461cf1092b&page=queryresults\">Open Job</a>"
],
"text/plain": [
"<IPython.core.display.HTML object>"
]
},
"metadata": {},
"output_type": "display_data"
},
{
"name": "stdout",
"output_type": "stream",
Expand All @@ -108,7 +96,7 @@
},
{
"cell_type": "code",
"execution_count": 5,
"execution_count": 4,
"id": "42bb02ab",
"metadata": {},
"outputs": [
Expand All @@ -135,19 +123,19 @@
},
{
"cell_type": "code",
"execution_count": 6,
"execution_count": 5,
"id": "ce250157",
"metadata": {},
"outputs": [
{
"data": {
"application/vnd.jupyter.widget-view+json": {
"model_id": "d2d4ef22ea9f414b89ea5bd85f0e6635",
"model_id": "a85f5799996d4de1a7912182c43fdf54",
"version_major": 2,
"version_minor": 1
},
"text/plain": [
"TableWidget(page_size=10, row_count=5552452, table_html='<table border=\"1\" class=\"table table-striped table-ho…"
"TableWidget(page_size=10, row_count=5552452, table_html='<table border=\"1\" class=\"dataframe table table-stripe…"
]
},
"metadata": {},
Expand All @@ -160,7 +148,7 @@
"Computation deferred. Computation will process 171.4 MB"
]
},
"execution_count": 6,
"execution_count": 5,
"metadata": {},
"output_type": "execute_result"
}
Expand All @@ -179,7 +167,7 @@
},
{
"cell_type": "code",
"execution_count": 7,
"execution_count": 6,
"id": "6920d49b",
"metadata": {},
"outputs": [
Expand All @@ -193,15 +181,15 @@
{
"data": {
"application/vnd.jupyter.widget-view+json": {
"model_id": "121e3d2f28004036a922e3a11a08d4b7",
"model_id": "261075a0d1d2487f804926884fe55eb2",
"version_major": 2,
"version_minor": 1
},
"text/plain": [
"TableWidget(page_size=10, row_count=5552452, table_html='<table border=\"1\" class=\"table table-striped table-ho…"
"TableWidget(page_size=10, row_count=5552452, table_html='<table border=\"1\" class=\"dataframe table table-stripe…"
]
},
"execution_count": 7,
"execution_count": 6,
"metadata": {},
"output_type": "execute_result"
}
Expand All @@ -228,7 +216,7 @@
},
{
"cell_type": "code",
"execution_count": 8,
"execution_count": 7,
"id": "12b68f15",
"metadata": {},
"outputs": [
Expand Down Expand Up @@ -265,15 +253,15 @@
},
{
"cell_type": "code",
"execution_count": 9,
"execution_count": 8,
"id": "a9d5d13a",
"metadata": {},
"outputs": [
{
"name": "stderr",
"output_type": "stream",
"text": [
"/usr/local/google/home/swast/src/github.com/googleapis/python-bigquery-dataframes/bigframes/core/array_value.py:230: AmbiguousWindowWarning: Window ordering may be ambiguous, this can cause unstable results.\n",
"/usr/local/google/home/swast/src/github.com/googleapis/python-bigquery-dataframes/bigframes/core/array_value.py:231: AmbiguousWindowWarning: Window ordering may be ambiguous, this can cause unstable results.\n",
" warnings.warn(msg, bfe.AmbiguousWindowWarning)\n"
]
},
Expand All @@ -287,15 +275,15 @@
{
"data": {
"application/vnd.jupyter.widget-view+json": {
"model_id": "5ed335bbbc064e5391ea06a9a218642e",
"model_id": "b37aec5d1c534e9f810e18c4fa7b8491",
"version_major": 2,
"version_minor": 1
},
"text/plain": [
"TableWidget(page_size=10, row_count=5, table_html='<table border=\"1\" class=\"table table-striped table-hover\" i…"
"TableWidget(page_size=10, row_count=5, table_html='<table border=\"1\" class=\"dataframe table table-striped tabl…"
]
},
"execution_count": 9,
"execution_count": 8,
"metadata": {},
"output_type": "execute_result"
}
Expand Down