Skip to content

fix: Prevent invalid syntax for no-op .replace ops #2112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 29, 2025
Merged

fix: Prevent invalid syntax for no-op .replace ops #2112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
65efa9b
fix: Prevent invalid syntax for no-op .replace ops
TrevorBergeron Sep 24, 2025
89a66dd
fix sqlglot compiler too
TrevorBergeron Sep 25, 2025
63a83d7
Merge remote-tracking branch 'github/main' into fix_solo_if_else
TrevorBergeron Sep 25, 2025
3d74176
Merge remote-tracking branch 'github/main' into fix_solo_if_else
TrevorBergeron Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions bigframes/core/compile/ibis_compiler/scalar_op_registry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1173,6 +1173,10 @@ def udf(*inputs):

@scalar_op_compiler.register_unary_op(ops.MapOp, pass_op=True)
def map_op_impl(x: ibis_types.Value, op: ops.MapOp):
Copy link
Contributor

@chelsea-lin chelsea-lin Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please check if the SQLGlot has the same issue: bigframes/core/compile/sqlglot/expressions/generic_ops.py

Copy link
Contributor Author

@TrevorBergeron TrevorBergeron Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, probably?

# this should probably be handled by a rewriter
if len(op.mappings) == 0:
return x

case = ibis_api.case()
for mapping in op.mappings:
case = case.when(x == mapping[0], mapping[1])
Expand Down
2 changes: 2 additions & 0 deletions bigframes/core/compile/sqlglot/expressions/generic_ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,8 @@ def _(expr: TypedExpr) -> sge.Expression:

@register_unary_op(ops.MapOp, pass_op=True)
def _(expr: TypedExpr, op: ops.MapOp) -> sge.Expression:
if len(op.mappings) == 0:
return expr.expr
return sge.Case(
this=expr.expr,
ifs=[
Expand Down
2 changes: 2 additions & 0 deletions tests/system/small/test_series.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -733,10 +733,12 @@ def test_series_replace_nans_with_pd_na(scalars_dfs):
(
({"Hello, World!": "Howdy, Planet!", "T": "R"},),
({},),
({0: "Hello, World!"},),
),
ids=[
"non-empty",
"empty",
"off-type",
],
)
def test_series_replace_dict(scalars_dfs, replacement_dict):
Expand Down