Skip to content

Conversation

@tswast
Copy link
Collaborator

@tswast tswast commented Sep 26, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

This change updates bigframes/formatting_helpers.py to render more event types from bigframes/core/events.py.

Specifically, it adds rendering support for:
- BigQueryRetryEvent
- BigQueryReceivedEvent
- BigQueryFinishedEvent
- BigQueryUnknownEvent

This provides users with more detailed feedback during query execution in both notebook (HTML) and terminal (plaintext) environments.
This change updates bigframes/formatting_helpers.py to render more event types from bigframes/core/events.py.

Specifically, it adds rendering support for:
- BigQueryRetryEvent
- BigQueryReceivedEvent
- BigQueryFinishedEvent
- BigQueryUnknownEvent

This provides users with more detailed feedback during query execution in both notebook (HTML) and terminal (plaintext) environments.

Unit tests have been added to verify the rendering of each new event type.
@tswast tswast requested review from a team as code owners September 26, 2025 17:40
@tswast tswast requested review from chelsea-lin and removed request for a team September 26, 2025 17:40
@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Sep 26, 2025
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Sep 26, 2025
@tswast tswast merged commit 2370ea2 into b409390651-progress-bar Sep 26, 2025
3 of 4 checks passed
@tswast tswast deleted the feat-render-more-events branch September 26, 2025 17:42
tswast added a commit that referenced this pull request Oct 8, 2025
* fix: show progress even in job optional queries

* first attempt at publisher

* report execution started/stopped in read_gbq_query

* render bigquery sent events

* Feat render more events (#2121)

* feat: Render more BigQuery events in progress bar

This change updates bigframes/formatting_helpers.py to render more event types from bigframes/core/events.py.

Specifically, it adds rendering support for:
- BigQueryRetryEvent
- BigQueryReceivedEvent
- BigQueryFinishedEvent
- BigQueryUnknownEvent

This provides users with more detailed feedback during query execution in both notebook (HTML) and terminal (plaintext) environments.

* feat: Render more BigQuery events in progress bar

This change updates bigframes/formatting_helpers.py to render more event types from bigframes/core/events.py.

Specifically, it adds rendering support for:
- BigQueryRetryEvent
- BigQueryReceivedEvent
- BigQueryFinishedEvent
- BigQueryUnknownEvent

This provides users with more detailed feedback during query execution in both notebook (HTML) and terminal (plaintext) environments.

Unit tests have been added to verify the rendering of each new event type.

---------

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>

* fix job links

* fix system tests

* fix mypy

* fix unit tests

* support more event types

* move publisher to session

* fix remaining mypy errors

* update text

* add explicit unsubscribe

* fix presubmits

* add lock for publisher and publish temp table creations

---------

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants