-
Notifications
You must be signed in to change notification settings - Fork 62
feat: add support for np.isnan and np.isfinite ufuncs
#2188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
1388ae7
feat: Implement isnan and isfinite in bigframes
google-labs-jules[bot] 2f13311
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] 07e677b
feat: Implement isnan and isfinite in bigframes
google-labs-jules[bot] 99afbda
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] 3b0af20
Apply suggestions from code review
tswast 8f67cb2
Update bigframes/core/compile/sqlglot/scalar_compiler.py
tswast aae2902
Update bigframes/core/compile/sqlglot/scalar_compiler.py
tswast 41ce94b
Update bigframes/core/compile/sqlglot/scalar_compiler.py
tswast c0b5e68
preserve NA
tswast 7f1bca4
fix annotations
tswast File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -348,3 +348,19 @@ def output_type(self, *input_types: dtypes.ExpressionType) -> dtypes.ExpressionT | |
| name="unsafe_pow_op", type_signature=op_typing.BINARY_REAL_NUMERIC | ||
| ) | ||
| unsafe_pow_op = UnsafePowOp() | ||
|
|
||
| IsNanOrNullOp = base_ops.create_unary_op( | ||
| name="isnanornull", | ||
|
||
| type_signature=op_typing.FixedOutputType( | ||
| dtypes.is_numeric, dtypes.BOOL_DTYPE, "numeric" | ||
| ), | ||
| ) | ||
| isnanornull_op = IsNanOrNullOp() | ||
|
|
||
| IsFiniteOp = base_ops.create_unary_op( | ||
| name="isfinite", | ||
| type_signature=op_typing.FixedOutputType( | ||
| dtypes.is_numeric, dtypes.BOOL_DTYPE, "numeric" | ||
| ), | ||
| ) | ||
| isfinite_op = IsFiniteOp() | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.