Skip to content

feat: Add df.groupby().corr()/cov() support #2190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2025
Merged

feat: Add df.groupby().corr()/cov() support #2190

merged 1 commit into from
Oct 23, 2025

Conversation

@TrevorBergeron
Copy link
Contributor

@TrevorBergeron TrevorBergeron commented Oct 22, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Oct 22, 2025
@TrevorBergeron TrevorBergeron marked this pull request as ready for review October 23, 2025 00:39
@TrevorBergeron TrevorBergeron requested review from a team as code owners October 23, 2025 00:39
tswast
tswast approved these changes Oct 23, 2025
View reviewed changes
Copy link
Collaborator

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bigframes/core/groupby/dataframe_group_by.py
for left_col in self._selected_cols
for right_col in self._selected_cols
]
# unique columns stops
Copy link
Collaborator

@tswast tswast Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I don't fully understand this comment, but I can infer from the context below that we're doing something to guarantee uniqueness here?

third_party/bigframes_vendored/pandas/core/groupby/__init__.py
**Examples:**
>>> df = bpd.DataFrame({'A': [1, 2, 3],
Copy link
Collaborator

@tswast tswast Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool to see that this works with the Polars session. :-)

@tswast tswast added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 23, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 23, 2025
@tswast tswast enabled auto-merge (squash) October 23, 2025 15:39
@tswast tswast merged commit ccd7c07 into main Oct 23, 2025
25 checks passed
@tswast tswast deleted the df_corr branch October 23, 2025 15:41
@release-please release-please bot mentioned this pull request Oct 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tswast tswast tswast approved these changes

@jialuoo jialuoo Awaiting requested review from jialuoo jialuoo is a code owner automatically assigned from googleapis/api-bigquery-dataframe

Assignees

@ivansmf ivansmf

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TrevorBergeron @tswast @ivansmf