Skip to content

Commit 4864ac9

Browse files
hugovkplamut
authored andcommitted
fix: replace unsafe six.PY3 with PY2 for better future compatibility with Python 4 (#10081)
* fix: fix for Python 4: replace unsafe six.PY3 with PY2 * Fix wording
1 parent ef62844 commit 4864ac9

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

google/cloud/storage/batch.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -214,10 +214,10 @@ def _prepare_batch_request(self):
214214
timeout = _timeout
215215

216216
# The `email` package expects to deal with "native" strings
217-
if six.PY3: # pragma: NO COVER Python3
218-
buf = io.StringIO()
219-
else:
217+
if six.PY2: # pragma: NO COVER Python3
220218
buf = io.BytesIO()
219+
else:
220+
buf = io.StringIO()
221221
generator = Generator(buf, False, 0)
222222
generator.flatten(multi)
223223
payload = buf.getvalue()

tests/unit/test__signing.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,8 +69,8 @@ def test_w_expiration_int(self):
6969
self.assertEqual(self._call_fut(123), 123)
7070

7171
def test_w_expiration_long(self):
72-
if six.PY3:
73-
raise unittest.SkipTest("No long on Python 3")
72+
if not six.PY2:
73+
raise unittest.SkipTest("No long on Python 3+")
7474

7575
self.assertEqual(self._call_fut(long(123)), 123) # noqa: F821
7676

0 commit comments

Comments
 (0)