Skip to content

feat!: upgrade to node24#1188

Merged
chingor13 merged 4 commits intogoogleapis:mainfrom
kwngo:feat/#1162/upgrade-to-node24
Apr 22, 2026
Merged

feat!: upgrade to node24#1188
chingor13 merged 4 commits intogoogleapis:mainfrom
kwngo:feat/#1162/upgrade-to-node24

Conversation

@kwngo
Copy link
Copy Markdown
Contributor

@kwngo kwngo commented Feb 24, 2026

Node v20 is going to be EOL in April 2026 -- https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/, and is being deprecated by Github on March 4 2026.

Addresses #1162

@google-cla
Copy link
Copy Markdown

google-cla Bot commented Feb 24, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@kwngo kwngo force-pushed the feat/#1162/upgrade-to-node24 branch 2 times, most recently from f9d6908 to 736364f Compare February 24, 2026 13:17
@kwngo kwngo force-pushed the feat/#1162/upgrade-to-node24 branch from 736364f to f241a89 Compare February 24, 2026 13:22
@ViacheslavKudinov
Copy link
Copy Markdown

ViacheslavKudinov commented Mar 15, 2026

HI,
its probably not only what needs to be done.
BTW it should be major version due to the specific GitHub version runner to be a dependency.
Eg v5.0.0 there https://github.com/googleapis/release-please-action/blob/main/package.json#L4,
could be node version https://github.com/googleapis/release-please-action/blob/main/package.json#L36 and https://github.com/googleapis/release-please-action/blob/main/package.json#L53,
changelog https://github.com/googleapis/release-please-action/blob/main/CHANGELOG.md and probably more.

Im not JS/TS person to be sure, but probably more places need to be updated.

PS Please, ignore, commented without knowing the release process.

@michaelfaith
Copy link
Copy Markdown

Eg v5.0.0 there https://github.com/googleapis/release-please-action/blob/main/package.json#L4c
changelog https://github.com/googleapis/release-please-action/blob/main/CHANGELOG.md

If you were familiar with the release please action, you'd know that it does this for you after PRs merge, in a release PR, and since this PR is using the correct PR title format, that will already be covered. 😊

@ViacheslavKudinov
Copy link
Copy Markdown

Eg v5.0.0 there https://github.com/googleapis/release-please-action/blob/main/package.json#L4c
changelog https://github.com/googleapis/release-please-action/blob/main/CHANGELOG.md

If you were familiar with the release please action, you'd know that it does this for you after PRs merge, in a release PR, and since this PR is using the correct PR title format, that will already be covered. 😊

Great to know.
Thank you for sharing.
Then we are good

Comment thread .github/workflows/ci.yaml
Comment thread .github/workflows/ci.yaml Outdated
Signed-off-by: Jeff Ching <chingor@google.com>
Signed-off-by: Jeff Ching <chingor@google.com>
@chingor13 chingor13 changed the title feat!: Upgrade to node24 feat!: upgrade to node24 Apr 22, 2026
@chingor13 chingor13 added this pull request to the merge queue Apr 22, 2026
Merged via the queue into googleapis:main with commit 46dfc01 Apr 22, 2026
9 checks passed
github-merge-queue Bot pushed a commit that referenced this pull request Apr 22, 2026
🤖 I have created a release *beep* *boop*
---


##
[5.0.0](v4.4.1...v5.0.0)
(2026-04-22)


### ⚠ BREAKING CHANGES

* upgrade to node24
([#1188](#1188))

### Features

* upgrade to node24
([#1188](#1188))
([46dfc01](46dfc01))


### Bug Fixes

* bump release-please from 17.3.0 to 17.6.0
([#1199](#1199))
([f533c26](f533c26))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants