Skip to content

[auto-approve] figure out how to allow commits from certain approved authors when checking author commit status #5349

Open
@sofisl

Description

@sofisl

Currently, there are some auto-approve checks that check if there were any other commits other than the approved author (for example, gcf-owl-bot). This is to ensure that malicious actors don't change code in a PR opened by a sanctioned author. However, this is overly restrictive in some cases, for example this pr wasn't approved because there was another author, danielbankhead. However, his commit was merging into main. Perhaps we want to ignore merges into main, or sanction an extra group of github users (i.e., those belonging to googleapis?)

@chingor13, lmk if you have any suggestions!

Metadata

Metadata

Assignees

Labels

priority: p2Moderately-important priority. Fix may not be included in next release.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions