Skip to content
This repository was archived by the owner on Sep 3, 2022. It is now read-only.

Commit 1213f76

Browse files
authored
Retry integration tests on any exception. (#2019)
The previous version of this logic retried a test if any of its `self.assert...` calls failed. However, that does not handle the case where a nested call to `datalab` fails. In those cases a `CalledProcessError` would be raised. To retry on those scenarios as well, we extend the retry logic to retry on any instance of the `Exception` class.
1 parent ebe71cb commit 1213f76

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

tools/cli/tests/end-to-end.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -187,8 +187,8 @@ def retry_test(self, test_method):
187187
try:
188188
test_method()
189189
return
190-
except AssertionError as ae:
191-
last_error = ae
190+
except Exception as ex:
191+
last_error = ex
192192
raise last_error
193193

194194
def test_create_delete(self):

0 commit comments

Comments
 (0)