Fix all flake8 warnings. Enable all flake8 codes except E111, E114, E121 (#315)

* Remove unused variables. Fix all flake8 warnings with code prefix F.

* Remove extra whitespaces. Fix all flake8 warnings with code prefix W.

* Fix all flake8 warnings with prefix E4,E5,E7.

* Fix all flake8 warnings with prefix E1,E2,E3.

* Remove flake8 filter on Travis-CI

* Fix all flake8 warnings on python 3.

Author: parthea

.travis.yml

@@ -22,7 +22,7 @@ before_install:
   - pip install flake8
 
 before_script:
-  - flake8 . --select=F401
+  - flake8 .
 
 script:
   - python ./tests/main.py

datalab/__init__.py

@@ -9,4 +9,3 @@
 # is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
 # or implied. See the License for the specific language governing permissions and limitations under
 # the License.
-

datalab/bigquery/__init__.py

@@ -33,6 +33,7 @@
            'QueryResultsTable', 'QueryStats', 'Sampling', 'Schema', 'Table', 'TableMetadata',
            'UDF', 'TableName', 'DatasetName', 'View']
 
+
 def wait_any(jobs, timeout=None):
   """ Return when at least one of the specified jobs has completed or timeout expires.
 

datalab/bigquery/_api.py

@@ -306,7 +306,7 @@ def datasets_update(self, dataset_name, dataset_info):
     """
     url = Api._ENDPOINT + (Api._DATASETS_PATH % dataset_name)
     return datalab.utils.Http.request(url, method='PUT', data=dataset_info,
-                                  credentials=self._credentials)
+                                      credentials=self._credentials)
 
   def datasets_get(self, dataset_name):
     """Issues a request to retrieve information about a dataset.
@@ -433,8 +433,8 @@ def tabledata_insert_all(self, table_name, rows):
     url = Api._ENDPOINT + (Api._TABLES_PATH % table_name) + "/insertAll"
 
     data = {
-      'kind': 'bigquery#tableDataInsertAllRequest',
-      'rows': rows
+        'kind': 'bigquery#tableDataInsertAllRequest',
+        'rows': rows
     }
 
     return datalab.utils.Http.request(url, data=data, credentials=self._credentials)
@@ -498,8 +498,8 @@ def table_extract(self, table_name, destination, format='CSV', compress=True,
     if isinstance(destination, basestring):
       destination = [destination]
     data = {
-      # 'projectId': table_name.project_id, # Code sample shows this but it is not in job
-      # reference spec. Filed as b/19235843
+        # 'projectId': table_name.project_id, # Code sample shows this but it is not in job
+        # reference spec. Filed as b/19235843
         'kind': 'bigquery#job',
         'configuration': {
             'extract': {

datalab/bigquery/_federated_table.py

@@ -95,4 +95,3 @@ def _to_query_json(self):
     if self._schema:
       json['schema'] = {'fields': self._schema._bq_schema}
     return json
-

datalab/bigquery/_query.py

@@ -423,9 +423,10 @@ def execute_dry_run(self, dialect=None, billing_tier=None):
       An exception if the query was malformed.
     """
     try:
-      query_result = self._api.jobs_insert_query(self._sql, self._code, self._imports, dry_run=True,
-                                                 table_definitions=self._external_tables, dialect=dialect,
-                                                 billing_tier=billing_tier)
+      query_result = self._api.jobs_insert_query(self._sql, self._code, self._imports,
+                                                 dry_run=True,
+                                                 table_definitions=self._external_tables,
+                                                 dialect=dialect, billing_tier=billing_tier)
     except Exception as e:
       raise e
     return query_result['statistics']['query']
@@ -540,4 +541,3 @@ def to_view(self, view_name):
     # Do the import here to avoid circular dependencies at top-level.
     from . import _view
     return _view.View(view_name, self._context).create(self._sql)
-

datalab/bigquery/_query_job.py

@@ -109,4 +109,3 @@ def results(self):
     if self.failed:
       raise Exception('Query failed: %s' % str(self.errors))
     return self._table
-

datalab/bigquery/_schema.py

@@ -264,7 +264,7 @@ def from_data(source):
           raise Exception(('Cannot create a schema from heterogeneous list %s; perhaps you meant ' +
                           'to use Schema.from_record?') % str(source))
       elif isinstance(source[0], list) and \
-          all([isinstance(l, list) and len(l) == len(source[0]) for l in source]):
+              all([isinstance(l, list) and len(l) == len(source[0]) for l in source]):
         # A list of lists all of the same length; treat first entry as a list record.
         bq_schema = Schema._from_record(source[0])
       else:

datalab/bigquery/_table.py

@@ -919,4 +919,3 @@ def to_query(self, fields=None):
     elif isinstance(fields, list):
       fields = ','.join(fields)
     return _query.Query('SELECT %s FROM %s' % (fields, self._repr_sql_()), context=self._context)
-

datalab/bigquery/_udf.py

@@ -78,11 +78,7 @@ def _build_js(inputs, outputs, name, implementation, support_code):
     # Build the JS from the individual bits with proper escaping of the implementation
     if support_code is None:
       support_code = ''
-    return ('{code}\n{name}={implementation};\n' +
-            'bigquery.defineFunction(\'{name}\', {inputs}, {outputs}, {name});')\
-                .format(code=support_code,
-                        name=name,
-                        implementation=implementation,
-                        inputs=str(input_fields),
-                        outputs=str(output_fields))
-
+    return ('{code}\n{name}={implementation};\nbigquery.defineFunction(\'{name}\', {inputs}, '
+            '{outputs}, {name});').format(code=support_code, name=name,
+                                          implementation=implementation, inputs=str(input_fields),
+                                          outputs=str(output_fields))