-
Notifications
You must be signed in to change notification settings - Fork 2.5k
SignIn Dialog from GoogleSignInClient.getSignInIntent() not returning correct result after rotation #345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@aaronvargas thanks for this report. I can confirm that is the case, I will look into it. |
Hmm looks like this is a known issue (69275024 internally) I will chase it down. Thanks for the reminder! |
Has this bug been resolved? |
@vinaysshenoyhl no it has not yet been resolved, I will try and get an update on this issue. |
Awesome, thanks! I'm not in any particular hurry to see it resolved since it's not blocking us on anything, just wanted to confirm that the issue is still open and the error wasn't due to anything I was doing wrong. |
@samtstern I just encountered this issue myself and thought I'd broken stuff in my refactor! 😱 Hope this gets fixed soon, for now, I've added a hack. |
This should be fixed in the next release of play services (whatever comes after |
@samtstern we are still getting this error with version |
android.content.Intent com.google.android.gms.auth.api.signin.GoogleSignInClient.getSignInIntent()' on a null object reference explain please |
Is it resolved? I am having same issue now too. As an workaround, I did following handling
|
When running the sample for SignInClient everything works correctly when no device rotation occurs. But if you rotate the device after showing the SignIn dialog you receive incorrect results in onActivityResult.
Steps to reproduce:
I've confirmed that there are not several attempts to startActivityForResult() for the signIn attempt as the error indicates.
https://developers.google.com/android/reference/com/google/android/gms/auth/api/signin/GoogleSignInStatusCodes.html#SIGN_IN_CURRENTLY_IN_PROGRESS
The text was updated successfully, but these errors were encountered: